Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044063ModulesAdvanced Warehouse Operationspublic2020-05-14 13:332020-06-01 12:40
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044063: Apply new HQL Style in StorageDetailUtils.java
DescriptionStorageDetailUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-14 13:33inigo_lergaNew Issue
2020-05-14 13:33inigo_lergaAssigned To => inigo_lerga
2020-05-14 13:34inigo_lergaRelationship addedrelated to 0041287
2020-05-14 13:38inigo_lergaStatusnew => scheduled
2020-05-14 13:51inigo_lergaNote Added: 0119880
2020-05-15 11:55inigo_lergaNote Edited: 0119880bug_revision_view_page.php?bugnote_id=0119880#r21028
2020-06-01 12:39hgbotCheckin
2020-06-01 12:39hgbotNote Added: 0120483
2020-06-01 12:39hgbotStatusscheduled => resolved
2020-06-01 12:39hgbotResolutionopen => fixed
2020-06-01 12:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/50e6de077a680953899edad12aafb39d8bfc37b0 [^]
2020-06-01 12:39hgbotCheckin
2020-06-01 12:39hgbotNote Added: 0120484
2020-06-01 12:40dmiguelezReview Assigned To => dmiguelez
2020-06-01 12:40dmiguelezNote Added: 0120485
2020-06-01 12:40dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119880)
inigo_lerga   
2020-05-14 13:51   
(edited on: 2020-05-15 11:55)
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs is executed#
(0120483)
hgbot   
2020-06-01 12:39   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 50e6de077a680953899edad12aafb39d8bfc37b0
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 14 13:46:12 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/50e6de077a680953899edad12aafb39d8bfc37b0 [^]

fixes BUG-44063:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/StorageDetailUtils.java
---
(0120484)
hgbot   
2020-06-01 12:39   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: bcb5dc979829b848c89241c5deece0469ec63539
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jun 01 12:39:23 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/bcb5dc979829b848c89241c5deece0469ec63539 [^]

Related to ISSUE-44063. Removed unnecessary variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/StorageDetailUtils.java
---
(0120485)
dmiguelez   
2020-06-01 12:40   
Code Review + Testing Ok