Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044059ModulesAdvanced Warehouse Operationspublic2020-05-14 09:192020-05-21 11:58
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044059: Apply new HQL Style in NegativeStockUtils.java
DescriptionNegativeStockUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-14 09:19inigo_lergaNew Issue
2020-05-14 09:19inigo_lergaAssigned To => inigo_lerga
2020-05-14 09:19inigo_lergaRelationship addedrelated to 0041287
2020-05-14 09:19inigo_lergaStatusnew => scheduled
2020-05-14 09:44inigo_lergaNote Added: 0119854
2020-05-15 11:57inigo_lergaNote Edited: 0119854bug_revision_view_page.php?bugnote_id=0119854#r21034
2020-05-15 11:59inigo_lergaNote Edited: 0119854bug_revision_view_page.php?bugnote_id=0119854#r21039
2020-05-21 11:57hgbotCheckin
2020-05-21 11:57hgbotNote Added: 0120122
2020-05-21 11:57hgbotStatusscheduled => resolved
2020-05-21 11:57hgbotResolutionopen => fixed
2020-05-21 11:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/49701828aa9100ebe3669d757cfaca0fc87891e2 [^]
2020-05-21 11:58dmiguelezReview Assigned To => dmiguelez
2020-05-21 11:58dmiguelezNote Added: 0120123
2020-05-21 11:58dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119854)
inigo_lerga   
2020-05-14 09:44   
(edited on: 2020-05-15 11:59)
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120122)
hgbot   
2020-05-21 11:57   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 49701828aa9100ebe3669d757cfaca0fc87891e2
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 14 09:55:48 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/49701828aa9100ebe3669d757cfaca0fc87891e2 [^]

fixes BUG-44059:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/NegativeStockUtils.java
---
(0120123)
dmiguelez   
2020-05-21 11:58   
Code Review + Testing Ok