Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044042ModulesAdvanced Warehouse Operationspublic2020-05-12 11:342020-05-19 19:05
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044042: Apply new HQL Style in OccupancyUtils.java
DescriptionOccupancyUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-12 11:34inigo_lergaNew Issue
2020-05-12 11:34inigo_lergaAssigned To => inigo_lerga
2020-05-12 11:35inigo_lergaStatusnew => scheduled
2020-05-12 11:35inigo_lergaRelationship addedrelated to 0041287
2020-05-12 11:49inigo_lergaNote Added: 0119769
2020-05-15 11:59inigo_lergaNote Edited: 0119769bug_revision_view_page.php?bugnote_id=0119769#r21043
2020-05-19 19:04hgbotCheckin
2020-05-19 19:04hgbotNote Added: 0120066
2020-05-19 19:04hgbotStatusscheduled => resolved
2020-05-19 19:04hgbotResolutionopen => fixed
2020-05-19 19:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/452fa02bbc8f8ef4468fe6596c1f4d482914a5dd [^]
2020-05-19 19:04hgbotCheckin
2020-05-19 19:04hgbotNote Added: 0120067
2020-05-19 19:05dmiguelezReview Assigned To => dmiguelez
2020-05-19 19:05dmiguelezNote Added: 0120068
2020-05-19 19:05dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119769)
inigo_lerga   
2020-05-12 11:49   
(edited on: 2020-05-15 11:59)
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120066)
hgbot   
2020-05-19 19:04   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 452fa02bbc8f8ef4468fe6596c1f4d482914a5dd
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 12 13:28:31 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/452fa02bbc8f8ef4468fe6596c1f4d482914a5dd [^]

fixes BUG-44042:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyUtils.java
---
(0120067)
hgbot   
2020-05-19 19:04   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 624efeb5464d240d710b7af6f5103614e39232c8
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue May 19 19:04:27 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/624efeb5464d240d710b7af6f5103614e39232c8 [^]

Related to ISSUE-44042 Code Review changes:
  * Removed unnecessary variable
  * Remove new lines to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/occupancy/OccupancyUtils.java
---
(0120068)
dmiguelez   
2020-05-19 19:05   
Code Review + Testing Ok