Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044017ModulesAdvanced Warehouse Operationspublic2020-05-08 14:382020-05-19 15:56
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044017: Apply new HQL Style in TasksProvider.java
DescriptionTasksProvider.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-08 14:38inigo_lergaNew Issue
2020-05-08 14:38inigo_lergaAssigned To => inigo_lerga
2020-05-08 14:38inigo_lergaRelationship addedrelated to 0041287
2020-05-08 14:38inigo_lergaStatusnew => scheduled
2020-05-08 14:51inigo_lergaNote Added: 0119711
2020-05-19 15:55hgbotCheckin
2020-05-19 15:55hgbotNote Added: 0120048
2020-05-19 15:55hgbotStatusscheduled => resolved
2020-05-19 15:55hgbotResolutionopen => fixed
2020-05-19 15:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/97b285320133453b54fb6bf56e67f211763637f4 [^]
2020-05-19 15:55hgbotCheckin
2020-05-19 15:55hgbotNote Added: 0120049
2020-05-19 15:56dmiguelezReview Assigned To => dmiguelez
2020-05-19 15:56dmiguelezNote Added: 0120050
2020-05-19 15:56dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119711)
inigo_lerga   
2020-05-08 14:51   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO_US_W role open AWO Front End.

#In this moment (loading tasks) the modified HQL is executed#
(0120048)
hgbot   
2020-05-19 15:55   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 97b285320133453b54fb6bf56e67f211763637f4
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon May 11 09:50:18 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/97b285320133453b54fb6bf56e67f211763637f4 [^]

fixes BUG-44017:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/TasksProvider.java
---
(0120049)
hgbot   
2020-05-19 15:55   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 58b2e54550b34d8c07cf7a5103d13a2bb557124d
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue May 19 15:53:47 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/58b2e54550b34d8c07cf7a5103d13a2bb557124d [^]

Related to ISSUE-44017. Removed unnecessary variables.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/TasksProvider.java
---
(0120050)
dmiguelez   
2020-05-19 15:56   
Code Review + Testing Ok