Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043985ModulesAdvanced Warehouse Operationspublic2020-05-07 16:162020-05-18 19:16
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043985: Apply new HQL Style in TGC_SalesOrder_Issue.java
DescriptionTGC_SalesOrder_Issue.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-07 16:16inigo_lergaNew Issue
2020-05-07 16:16inigo_lergaAssigned To => inigo_lerga
2020-05-07 16:16inigo_lergaRelationship addedrelated to 0041287
2020-05-07 16:16inigo_lergaStatusnew => scheduled
2020-05-07 17:08inigo_lergaNote Added: 0119668
2020-05-18 18:56hgbotCheckin
2020-05-18 18:56hgbotNote Added: 0120006
2020-05-18 18:56hgbotStatusscheduled => resolved
2020-05-18 18:56hgbotResolutionopen => fixed
2020-05-18 18:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/8b6b552256d067de142c00707e9448889fded016 [^]
2020-05-18 19:16hgbotCheckin
2020-05-18 19:16hgbotNote Added: 0120008
2020-05-18 19:16dmiguelezReview Assigned To => dmiguelez
2020-05-18 19:16dmiguelezNote Added: 0120009
2020-05-18 19:16dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119668)
inigo_lerga   
2020-05-07 17:08   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO-QA Admin - AWO-QA role:
  - Go to the Sales Order window and create a new record
    with any Business Partner desired.
    Go to Lines Tab and create a new Line with any product and
    quantity desired.
    Book the Sales Order and copy the Search Key.

As the AWO_US_W role in AWO Front End:
  - Open the Issue window and paste the Search Key. Press search button.

  #In this moment the modified HQL is executed#
(0120006)
hgbot   
2020-05-18 18:56   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 8b6b552256d067de142c00707e9448889fded016
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 07 17:15:40 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/8b6b552256d067de142c00707e9448889fded016 [^]

fixes BUG-43985:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_SalesOrder_Issue.java
---
(0120008)
hgbot   
2020-05-18 19:16   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: c4e2eff079b4bc1bb481242f1fba8ebc61c391b9
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon May 18 19:15:53 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/c4e2eff079b4bc1bb481242f1fba8ebc61c391b9 [^]

Related to ISSUE-43985. Refactor of class
* Logic to create additional where clause extracted to different method
* Added final modifiers
* Remove unnecessary writableOrgsInClause variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_SalesOrder_Issue.java
---
(0120009)
dmiguelez   
2020-05-18 19:16   
Code Review + Testing Ok