Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043978Openbravo ERPA. Platformpublic2020-05-07 13:202020-05-21 13:09
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043978: Remove "classic popup tree view" which has been obsolete by "Tree Extension" project in 14Q2
DescriptionThe "Tree Extension" project from 14Q2 release implemented:
- Adding new Tree's using modules instead of needing to modify Openbravo core java files
- It also re-implemented the UI for Tree's using modern technology (smartclient) instead of old manually coded HTML inside a 'popup'.

Back then the old implementation was kept available if the preference OBUIAPP_UseClassicTreeView: "Use Classic Popup Tree" is set.

The old implementation should be removed as it is now:
- 6 years later
- The old code is missing all the project benefits (better UI, extendable cleanly)

Steps To Reproducehttps://issues.openbravo.com/view.php?id=25906 [^]
http://wiki.openbravo.com/wiki/Projects/Tree_Extension/Functional_Specifications [^]
Proposed SolutionDelete the preference and the old implementation.
Behavior would be that instances still using the old implementation today would be silently switched to the 'new UI'.

It would be possible to add either on top:

- WAD validation to inform during compilation if that preference is still set
- Add BuildValidation to stop update if that preference is set to ensure people
are clearly notified.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00259063.0PR14Q2 closed AugustoMauch Tree Extension Project 
depends on defect 0044010 closed platform API change: old tree implementation 
blocks design defect 0032688 acknowledged Triage Platform Base remove unused resources 
blocks design defect 0044014 new Triage Platform Base remove obsolete DHTMLgoodies libraries 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-07 13:20shuehnerNew Issue
2020-05-07 13:20shuehnerAssigned To => platform
2020-05-07 13:20shuehnerModules => Core
2020-05-07 13:20shuehnerTriggers an Emergency Pack => No
2020-05-08 13:07alostaleRelationship addedrelated to 0025906
2020-05-08 13:08alostaleRelationship addedblocks 0032688
2020-05-08 13:08alostaleNote Added: 0119696
2020-05-08 13:24alostaleRelationship addeddepends on 0044010
2020-05-08 13:57alostaleRelationship addedblocks 0044014
2020-05-21 12:36alostaleNote Added: 0120127
2020-05-21 13:03hgbotCheckin
2020-05-21 13:03hgbotNote Added: 0120130
2020-05-21 13:03hgbotStatusnew => resolved
2020-05-21 13:03hgbotResolutionopen => fixed
2020-05-21 13:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6c4fa9f73df9b55d84749715efa70a5cdf5fb0af [^]
2020-05-21 13:09alostaleAssigned Toplatform => shuehner
2020-05-21 13:09alostaleReview Assigned To => alostale
2020-05-21 13:09alostaleStatusresolved => closed
2020-05-21 13:09alostaleFixed in Version => 3.0PR20Q3

Notes
(0119696)
alostale   
2020-05-08 13:08   
MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/70 [^]
(0120127)
alostale   
2020-05-21 12:36   
Discussed with support no known users of old implementation so it isn't worth the effort to do any WAD/Build validation
(0120130)
hgbot   
2020-05-21 13:03   
Repository: erp/devel/pi
Changeset: 6c4fa9f73df9b55d84749715efa70a5cdf5fb0af
Author: Stefan Huehner <stefan.huehner <at> openbravo.com>
Date: Fri May 08 12:49:45 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6c4fa9f73df9b55d84749715efa70a5cdf5fb0af [^]

fixed FR-43978: remove obsolete tree implementation

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_REF_LIST.xml
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/erpCommon/utility/WindowTree_data.xsql
R src/org/openbravo/erpCommon/utility/WindowTree.html
R src/org/openbravo/erpCommon/utility/WindowTree.java
R src/org/openbravo/erpCommon/utility/WindowTree.xml
R src/org/openbravo/erpCommon/utility/WindowTreeChecks.java
R src/org/openbravo/erpCommon/utility/WindowTreeChecksClient.java
R src/org/openbravo/erpCommon/utility/WindowTreeChecks_data.xsql
R src/org/openbravo/erpCommon/utility/WindowTreeUtility.java
---