Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043974Openbravo ERP02. Master data managementpublic2020-05-06 19:452020-05-26 12:52
Reportersdossantos 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerGold
Web browser
ModulesCore
Support ticket15940
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043974: In sales order when navigating the Delivery Location record is modified with another address whit the same address name
DescriptionWhen two busines partner share the same name for two different addresses, and creating two consecutive sales orders one with each of these business partner. When editing the first sales order, if the delivery address is navigated, then this record is changed with the record of the address of the other business partner (of the second sales order created), this create problems with shipments (these orders are sent to addresses of other business partner). If this record is saved without knowing that this change was made (closing the form view or changing the focus to the order lines) or if any modification is made in another field and it is saved, it generates the problem of Shipping.
Steps To Reproduce1) Create two business partners (or update existing) adding on each one a new business partner address, same name for these addresses.
2) Create a new sales order, in form mode, with first business partner using the adress created in Delivery Location field. Add a product and book this order.
3) Create a new sales order, in form mode, with second business partner using the adress created in Delivery Location field. Save this record.
4) Close form mode and open first sales order created and navigate Delivery Location field.

At this point, the first sales order created was modified seting Delivery Location of second sales order created. If you make a change in other field and save this order you has modified the Delivery Location field permantly or if you accidentaly save this order.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files? Video.tar.xz (4,495,916) 2020-05-06 19:50
https://issues.openbravo.com/file_download.php?file_id=14437&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-05-06 19:45sdossantosNew Issue
2020-05-06 19:45sdossantosAssigned To => Triage Finance
2020-05-06 19:45sdossantosModules => Core
2020-05-06 19:45sdossantosTriggers an Emergency Pack => No
2020-05-06 19:50sdossantosFile Added: Video.tar.xz
2020-05-06 20:25matias-bernalOBNetwork customer => Gold
2020-05-06 20:25matias-bernalSupport ticket => 15940
2020-05-07 08:33dmiguelezResolution time => 1590530400
2020-05-07 08:34dmiguelezAssigned ToTriage Finance => platform
2020-05-07 09:25jfrancesIssue Monitored: jfrances
2020-05-14 20:02matias-bernalIssue Monitored: matias-bernal
2020-05-21 13:25cbernerAssigned Toplatform => cberner
2020-05-21 13:25cbernerStatusnew => scheduled
2020-05-21 13:25cbernerReview Assigned To => alostale
2020-05-22 10:44alostaleNote Added: 0120165
2020-05-26 12:42hgbotCheckin
2020-05-26 12:42hgbotNote Added: 0120286
2020-05-26 12:42hgbotStatusscheduled => resolved
2020-05-26 12:42hgbotResolutionopen => fixed
2020-05-26 12:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1766912da85a42f6b3a96d51fafe45f6b45a1b0f [^]
2020-05-26 12:52alostaleNote Added: 0120287
2020-05-26 12:52alostaleStatusresolved => closed
2020-05-26 12:52alostaleFixed in Version => 3.0PR20Q3

Notes
(0120165)
alostale   
2020-05-22 10:44   
MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/74 [^]
(0120286)
hgbot   
2020-05-26 12:42   
Repository: erp/devel/pi
Changeset: 1766912da85a42f6b3a96d51fafe45f6b45a1b0f
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Thu May 21 13:14:11 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1766912da85a42f6b3a96d51fafe45f6b45a1b0f [^]

Fixes ISSUE-43974: Select correct combo-box element when using same display name

mapDisplayToValue default implementation is not updating its reverse picked cache, it kept its value despite changing records if pickValue wasn't called again.
This resulted in combo boxes from forms selecting values from previous records, not present on the current record

mapDisplayToValue has been reimplemented to avoid the side-effects of the inherited implementation

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-combo.js
---
(0120287)
alostale   
2020-05-26 12:52   
reviewed