Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043967ModulesAdvanced Warehouse Operationspublic2020-05-06 14:062020-05-18 13:28
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043967: Apply new HQL Style in PutAwayMoveChangeStatusStorageDetail_ITT.java
DescriptionPutAwayMoveChangeStatusStorageDetail_ITT.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-06 14:06inigo_lergaNew Issue
2020-05-06 14:06inigo_lergaAssigned To => inigo_lerga
2020-05-06 14:06inigo_lergaRelationship addedrelated to 0041287
2020-05-06 14:07inigo_lergaStatusnew => scheduled
2020-05-06 14:32inigo_lergaNote Added: 0119633
2020-05-18 13:27hgbotCheckin
2020-05-18 13:27hgbotNote Added: 0119982
2020-05-18 13:27hgbotStatusscheduled => resolved
2020-05-18 13:27hgbotResolutionopen => fixed
2020-05-18 13:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/1003a470bd74116b23b12c32a525a5e523589c22 [^]
2020-05-18 13:27hgbotCheckin
2020-05-18 13:27hgbotNote Added: 0119983
2020-05-18 13:28dmiguelezReview Assigned To => dmiguelez
2020-05-18 13:28dmiguelezNote Added: 0119984
2020-05-18 13:28dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119633)
inigo_lerga   
2020-05-06 14:32   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are updated#
(0119982)
hgbot   
2020-05-18 13:27   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 1003a470bd74116b23b12c32a525a5e523589c22
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 06 14:29:02 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/1003a470bd74116b23b12c32a525a5e523589c22 [^]

fixes BUG-43967:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/PutAwayMoveChangeStatusStorageDetail_ITT.java
---
(0119983)
hgbot   
2020-05-18 13:27   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: a0c976e3b725a9c23b54ab42fcf720f5932294e7
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon May 18 13:26:21 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/a0c976e3b725a9c23b54ab42fcf720f5932294e7 [^]

Related to ISSUE-43967. Removed unnecessary variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/PutAwayMoveChangeStatusStorageDetail_ITT.java
---
(0119984)
dmiguelez   
2020-05-18 13:28   
Code Review + Testing Ok