Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043966ModulesAdvanced Warehouse Operationspublic2020-05-06 13:122020-05-18 13:01
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043966: Apply new HQL Style in Picking_ITT.java
DescriptionPicking_ITT.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-06 13:12inigo_lergaNew Issue
2020-05-06 13:12inigo_lergaAssigned To => inigo_lerga
2020-05-06 13:12inigo_lergaRelationship addedrelated to 0041287
2020-05-06 13:12inigo_lergaStatusnew => scheduled
2020-05-06 14:31inigo_lergaNote Added: 0119632
2020-05-06 14:32inigo_lergaNote Edited: 0119632bug_revision_view_page.php?bugnote_id=0119632#r20950
2020-05-18 13:00hgbotCheckin
2020-05-18 13:00hgbotNote Added: 0119978
2020-05-18 13:00hgbotStatusscheduled => resolved
2020-05-18 13:00hgbotResolutionopen => fixed
2020-05-18 13:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/40165061b40b5287ab6c74eddbf6ce456f306216 [^]
2020-05-18 13:00hgbotCheckin
2020-05-18 13:00hgbotNote Added: 0119979
2020-05-18 13:01dmiguelezReview Assigned To => dmiguelez
2020-05-18 13:01dmiguelezNote Added: 0119980
2020-05-18 13:01dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119632)
inigo_lerga   
2020-05-06 14:31   
(edited on: 2020-05-06 14:32)
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are updated#
(0119978)
hgbot   
2020-05-18 13:00   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 40165061b40b5287ab6c74eddbf6ce456f306216
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 06 14:02:10 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/40165061b40b5287ab6c74eddbf6ce456f306216 [^]

fixes BUG-43966:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/Picking_ITT.java
---
(0119979)
hgbot   
2020-05-18 13:00   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 8765bdf138dd2ddcee982529a5902f3ad5f92181
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon May 18 13:00:47 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/8765bdf138dd2ddcee982529a5902f3ad5f92181 [^]

Related to ISSUE-43966. Removed unnecessary variables

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/Picking_ITT.java
---
(0119980)
dmiguelez   
2020-05-18 13:01   
Code Review + Testing Ok