Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043958ModulesAdvanced Warehouse Operationspublic2020-05-06 11:292020-05-18 12:41
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043958: Apply new HQL Style in ReceiptPurchaseOrder_ITTAlgorithmDao.java
DescriptionReceiptPurchaseOrder_ITTAlgorithmDao.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-06 11:29inigo_lergaNew Issue
2020-05-06 11:29inigo_lergaAssigned To => inigo_lerga
2020-05-06 11:33inigo_lergaStatusnew => scheduled
2020-05-06 11:33inigo_lergaRelationship addedrelated to 0041287
2020-05-18 12:07inigo_lergaNote Added: 0119971
2020-05-18 12:40hgbotCheckin
2020-05-18 12:40hgbotNote Added: 0119975
2020-05-18 12:40hgbotStatusscheduled => resolved
2020-05-18 12:40hgbotResolutionopen => fixed
2020-05-18 12:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/15717b09f4f6a05513f690d9b28925800143fcc8 [^]
2020-05-18 12:40hgbotCheckin
2020-05-18 12:40hgbotNote Added: 0119976
2020-05-18 12:41dmiguelezReview Assigned To => dmiguelez
2020-05-18 12:41dmiguelezNote Added: 0119977
2020-05-18 12:41dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119971)
inigo_lerga   
2020-05-18 12:07   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are updated#
(0119975)
hgbot   
2020-05-18 12:40   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 15717b09f4f6a05513f690d9b28925800143fcc8
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 06 13:09:59 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/15717b09f4f6a05513f690d9b28925800143fcc8 [^]

fixes BUG-43958:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/implementation/ReceiptPurchaseOrder_ITTAlgorithmDao.java
---
(0119976)
hgbot   
2020-05-18 12:40   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: c1a50a17c78e7a85a955c9287d36ec2e9f4f06f9
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon May 18 12:40:51 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/c1a50a17c78e7a85a955c9287d36ec2e9f4f06f9 [^]

Related to ISSUE-43958. Removed unnecessary variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/implementation/ReceiptPurchaseOrder_ITTAlgorithmDao.java
---
(0119977)
dmiguelez   
2020-05-18 12:41   
Code Review + Testing Ok