Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043956ModulesAdvanced Warehouse Operationspublic2020-05-06 10:142020-05-18 12:04
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043956: Apply new HQL Style in CountPhysicalInventory_ITTAlgorithmDao.java
DescriptionCountPhysicalInventory_ITTAlgorithmDao.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-06 10:14inigo_lergaNew Issue
2020-05-06 10:14inigo_lergaAssigned To => inigo_lerga
2020-05-06 10:14inigo_lergaStatusnew => scheduled
2020-05-06 10:14inigo_lergaRelationship addedrelated to 0041287
2020-05-06 14:31inigo_lergaNote Added: 0119631
2020-05-06 14:32inigo_lergaNote Edited: 0119631bug_revision_view_page.php?bugnote_id=0119631#r20952
2020-05-18 11:59hgbotCheckin
2020-05-18 11:59hgbotNote Added: 0119968
2020-05-18 11:59hgbotStatusscheduled => resolved
2020-05-18 11:59hgbotResolutionopen => fixed
2020-05-18 11:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/7c4861ffda3e50de7ada56693d5af3abfd43af1e [^]
2020-05-18 11:59hgbotCheckin
2020-05-18 11:59hgbotNote Added: 0119969
2020-05-18 12:04dmiguelezReview Assigned To => dmiguelez
2020-05-18 12:04dmiguelezNote Added: 0119970
2020-05-18 12:04dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119631)
inigo_lerga   
2020-05-06 14:31   
(edited on: 2020-05-06 14:32)
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are updated#
(0119968)
hgbot   
2020-05-18 11:59   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 7c4861ffda3e50de7ada56693d5af3abfd43af1e
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 06 11:21:48 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/7c4861ffda3e50de7ada56693d5af3abfd43af1e [^]

fixes BUG-43956:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/implementation/CountPhysicalInventory_ITTAlgorithmDao.java
---
(0119969)
hgbot   
2020-05-18 11:59   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 0f21e42e259da7539a3a3b62e9f11c442aed726f
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon May 18 11:59:13 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0f21e42e259da7539a3a3b62e9f11c442aed726f [^]

Related to ISSUE-43956: Removed unnecessary variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/implementation/CountPhysicalInventory_ITTAlgorithmDao.java
---
(0119970)
dmiguelez   
2020-05-18 12:04   
Code Review + Testing Ok