Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043941ModulesAdvanced Warehouse Operationspublic2020-05-05 13:442020-05-18 11:22
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043941: Apply new HQL Style in IssueITTDao.java
DescriptionIssueITTDao.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-05 13:44inigo_lergaNew Issue
2020-05-05 13:44inigo_lergaAssigned To => inigo_lerga
2020-05-05 13:44inigo_lergaRelationship addedrelated to 0041287
2020-05-05 13:44inigo_lergaStatusnew => scheduled
2020-05-05 15:20inigo_lergaNote Added: 0119587
2020-05-18 11:21hgbotCheckin
2020-05-18 11:21hgbotNote Added: 0119962
2020-05-18 11:21hgbotStatusscheduled => resolved
2020-05-18 11:21hgbotResolutionopen => fixed
2020-05-18 11:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/1f9214190c8aaf2512704179f06e44d928381b5e [^]
2020-05-18 11:21hgbotCheckin
2020-05-18 11:21hgbotNote Added: 0119963
2020-05-18 11:22dmiguelezReview Assigned To => dmiguelez
2020-05-18 11:22dmiguelezNote Added: 0119964
2020-05-18 11:22dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119587)
inigo_lerga   
2020-05-05 15:20   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are updated#
(0119962)
hgbot   
2020-05-18 11:21   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 1f9214190c8aaf2512704179f06e44d928381b5e
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 05 15:29:55 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/1f9214190c8aaf2512704179f06e44d928381b5e [^]

fixes BUG-43941:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/dao/IssueITTDao.java
---
(0119963)
hgbot   
2020-05-18 11:21   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 973770ee90f6e22ae00541310f6e229ad79bb8bf
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon May 18 11:21:04 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/973770ee90f6e22ae00541310f6e229ad79bb8bf [^]

Related to ISSUE-43941. Removed unnecessary variables and empty comments

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/dao/IssueITTDao.java
---
(0119964)
dmiguelez   
2020-05-18 11:22   
Code Review + Testing Ok