Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043936ModulesAdvanced Warehouse Operationspublic2020-05-05 12:362020-05-15 11:33
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043936: Apply new HQL Style in RecalculateOccupancyHandler.java
DescriptionRecalculateOccupancyHandler.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-05 12:36inigo_lergaNew Issue
2020-05-05 12:36inigo_lergaAssigned To => inigo_lerga
2020-05-05 12:36inigo_lergaRelationship addedrelated to 0041287
2020-05-05 12:37inigo_lergaStatusnew => scheduled
2020-05-05 12:58inigo_lergaNote Added: 0119581
2020-05-05 12:59inigo_lergaNote Deleted: 0119581
2020-05-05 13:01inigo_lergaNote Added: 0119583
2020-05-05 13:37inigo_lergaNote Added: 0119584
2020-05-05 13:37inigo_lergaNote Deleted: 0119584
2020-05-15 11:32hgbotCheckin
2020-05-15 11:32hgbotNote Added: 0119936
2020-05-15 11:32hgbotStatusscheduled => resolved
2020-05-15 11:32hgbotResolutionopen => fixed
2020-05-15 11:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/b44884b551bb3f138d39eb27b097d036a593a3f6 [^]
2020-05-15 11:33dmiguelezReview Assigned To => dmiguelez
2020-05-15 11:33dmiguelezNote Added: 0119937
2020-05-15 11:33dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119583)
inigo_lerga   
2020-05-05 13:01   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
As the AWO-QA Admin - AWO-QA role:
  - Go to the Recalculate Occupancy window. Select any desired values
    in the available fields and press the Done button.

  #In this moment the modified HQL is executed#
(0119936)
hgbot   
2020-05-15 11:32   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: b44884b551bb3f138d39eb27b097d036a593a3f6
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 05 13:05:20 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/b44884b551bb3f138d39eb27b097d036a593a3f6 [^]

fixes BUG-43936:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/handler/RecalculateOccupancyHandler.java
---
(0119937)
dmiguelez   
2020-05-15 11:33   
Code Review + Testing Ok