Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043831Openbravo ERP09. Financial managementpublic2020-04-22 21:372020-06-05 10:08
Reporterlbressan 
Assigned Toinigo_lerga 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q3 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket15656
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043831: Error processing G/L Journal with date format MM-DD-YYYY
DescriptionConfiguring the MM-DD-YYYY date format for an environment and creating the header of a G / L Journal will not allow you to create the lines or process it, since it throws an error in the class org.openbravo.erpCommon.ad_callouts.SLJournalPeriodData
Since the date format DD-MM-YYYY is being set in the "getCurrencyRate" function, so it is incompatible and throws an error.
(SLJournalPeriodData.png)
Steps To Reproduce0. Openbravo.properties is configured (Configuracion_en_OB_Properties.png)
1. Create a G/L Journal header dated 04-17-2020
It does not allow you to create lines, nor to process the G/L Journal (GLJournal_Fecha_Incompatible.png)
Proposed SolutionIt must be changed to read the date format configured in the Openbravo.properties
Additional Information
TagsNo tags attached.
Relationships
Attached Fileszip imgs.zip (179,888) 2020-04-22 21:37
https://issues.openbravo.com/file_download.php?file_id=14365&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-04-22 21:37lbressanNew Issue
2020-04-22 21:37lbressanAssigned To => Triage Finance
2020-04-22 21:37lbressanFile Added: imgs.zip
2020-04-22 21:37lbressanOBNetwork customer => No
2020-04-22 21:37lbressanModules => Core
2020-04-22 21:37lbressanSupport ticket => 15656
2020-04-22 21:37lbressanResolution time => 1588888800
2020-04-22 21:37lbressanTriggers an Emergency Pack => No
2020-04-22 21:42lbressanReproducibilityhave not tried => always
2020-04-22 21:57lbressanProposed Solution updated
2020-04-28 08:11egoitzOBNetwork customerNo => OBPS
2020-04-28 16:22ngarciaResolution time1588888800 => 1589320800
2020-04-28 16:22ngarciaPrioritynormal => urgent
2020-04-28 16:22ngarciaSeverityminor => major
2020-04-28 16:34matias-bernalResolution time1589320800 => 1589338800
2020-04-28 16:34matias-bernalPriorityurgent => high
2020-04-30 09:23inigo_lergaAssigned ToTriage Finance => inigo_lerga
2020-04-30 09:23inigo_lergaStatusnew => scheduled
2020-05-08 11:58hgbotCheckin
2020-05-08 11:58hgbotNote Added: 0119684
2020-05-08 11:58dmiguelezStatusscheduled => resolved
2020-05-08 11:58dmiguelezFixed in Version => 3.0PR20Q3
2020-05-08 11:58dmiguelezFixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/ff56a9703ef53221aac471faafd1a026f03d03b0 [^]
2020-05-08 11:58dmiguelezResolutionopen => fixed
2020-05-08 12:00dmiguelezNote Added: 0119685
2020-05-08 12:02dmiguelezNote Added: 0119686
2020-05-08 12:02dmiguelezNote Edited: 0119686bug_revision_view_page.php?bugnote_id=0119686#r20985
2020-05-08 12:03dmiguelezReview Assigned To => dmiguelez
2020-05-08 12:03dmiguelezNote Added: 0119688
2020-05-08 12:03dmiguelezStatusresolved => closed
2020-06-05 10:08hudsonbotCheckin
2020-06-05 10:08hudsonbotNote Added: 0120688

Notes
(0119684)
hgbot   
2020-05-08 11:58   
Repository: erp/devel/pi
Changeset: ff56a9703ef53221aac471faafd1a026f03d03b0
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu May 07 17:35:43 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ff56a9703ef53221aac471faafd1a026f03d03b0 [^]

Related to Issue 43831. Removed the mask from the call to the TO_DATE
function in query

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Journal_Period_data.xsql
---
(0119685)
dmiguelez   
2020-05-08 12:00   
The problem with this issue is not the mask of the TO_DATE function itself, but a problem with the Openbravo.properties configuration.

In the steps reported, the configuration for the bbdd.sessionConfig was wrong, as it should have the same date mask as the one defined for the dateformat.sql:
http://wiki.openbravo.com/wiki/Openbravo.properties#Database [^]

With this configuration, the issue is no longer reproducible, however, the fix to remove the mask from the TO_DATE call has been done to improve the existing code.
(0119686)
dmiguelez   
2020-05-08 12:02   
Test Plan

0. Openbravo.properties is configured (Configuracion_en_OB_Properties.png)
1. Configure the bbdd.sessionConfig with the same mask as the one defined for the dateformat.sql
2. ant update.database compile.complete
3. Create a G/L Journal header dated 04-17-2020
Check that it is possible to create new lines and no errors are shown in the log
(0119688)
dmiguelez   
2020-05-08 12:03   
Code Review + Testing Ok
(0120688)
hudsonbot   
2020-06-05 10:08   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5df961d296a2 [^]
Maturity status: Test