0043760: Error when trying to delete orphan lines orphan lines on Return from Customer window

Openbravo Issue Tracking System - Openbravo ERP
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0043760	Openbravo ERP	07. Sales management	public	2020-04-17 00:33	2020-05-07 15:47

Reporter	matias-bernal
Assigned To	inigo_lerga
Priority	normal	Severity	major	Reproducibility	have not tried
Status	closed	Resolution	fixed
Platform		OS	5	OS Version
Product Version
Target Version		Fixed in Version	PR20Q3
Merge Request Status
Review Assigned To	dmiguelez
OBNetwork customer
Web browser
Modules	Core
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency Pack	No

Summary	0043760: Error when trying to delete orphan lines orphan lines on Return from Customer window
Description	After reactivating a Return from Customer record (with a line invoiced and received), we added an orphan line but we need to delete it now, the record is still on draft but we are getting an error when trying to delete the orphan line
Steps To Reproduce	RM Allow Orphan Line preference must be active 1- Create a sales order with a product, process it, invoice it and create the goods shipment 2- Create a Return from Customer, pick the sales order line, process it, invoice it and create the goods shipment 3- Reactivate the Return from Customer, insert an orphan line, then try to delete it It gives the error: "You cannot delete the line because it has Delivered Quantity -4" but the return wasn't processed yet and the orphan line wasn't delivered yet either https://www.youtube.com/watch?v=VFZmZvqnSCQ&feature=youtu.be [^]
Proposed Solution	See attached patch
Additional Information
Tags	No tags attached.
Relationships
Attached Files	ad_table.diff (1,284) 2020-04-22 18:21 https://issues.openbravo.com/file_download.php?file_id=14364&type=bug

Issue History
Date Modified	Username	Field	Change
2020-04-17 00:33	matias-bernal	New Issue
2020-04-17 00:33	matias-bernal	Assigned To	=> Triage Finance
2020-04-17 00:33	matias-bernal	Modules	=> Core
2020-04-17 00:33	matias-bernal	Triggers an Emergency Pack	=> No
2020-04-17 08:30	Practics	Issue Monitored: Practics
2020-04-22 18:19	matias-bernal	Proposed Solution updated
2020-04-22 18:21	matias-bernal	File Added: ad_table.diff
2020-04-23 08:22	dmiguelez	Resolution time	=> 1589320800
2020-04-29 08:47	inigo_lerga	Status	new => scheduled
2020-04-29 08:47	inigo_lerga	Assigned To	Triage Finance => inigo_lerga
2020-04-30 14:00	inigo_lerga	Note Added: 0119504
2020-05-07 15:45	hgbot	Checkin
2020-05-07 15:45	hgbot	Note Added: 0119662
2020-05-07 15:45	hgbot	Status	scheduled => resolved
2020-05-07 15:45	hgbot	Resolution	open => fixed
2020-05-07 15:45	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/47e4ca0c5c1a59445d70fad5fffb90f42f03f80b [^]
2020-05-07 15:47	dmiguelez	Note Added: 0119663
2020-05-07 15:47	dmiguelez	Review Assigned To	=> dmiguelez
2020-05-07 15:47	dmiguelez	Note Added: 0119664
2020-05-07 15:47	dmiguelez	Status	resolved => closed
2020-05-07 15:47	dmiguelez	Fixed in Version	=> 3.0PR20Q3

Notes

--Test Plan Mantis--
Beforehand, the environment needs to have enabled the following preference:
- RM Allow Orphan Line

IN THE BACKEND - As the F&B International Group Admin role:
- Go to the Sales Order window and create a new record with
  "Alimentos y Supermercados, S.A" as Business Partner, leaving
  the rest of the fields as default.
  Go to the Lines tab and create a new line with "Cerveza Ale 0,5L"
  as product and 5 units as Ordered Quantity.
  Save the record and book it.
- Go to the Create Shipments from Orders window, select the previously
  created record and process it.
- Go to the Create Invoices from Orders window and select the previously
  created record and process it.
- Go to the Return from Customer window and create a new record with
  "Alimentos y Supermercados, S.A" as Business Partner, leaving
  the rest of the fields as default.
  Press the Pick/Edit Lines button and select the 5 units of Cerveza Ale of
  the previously created Sales Order. Set 5 as Returned Quantity.
  Book the record.
- Go to the Return Material Receipt window and create a new record with
  "Alimentos y Supermercados, S.A" as Business Partner, leaving
  the rest of the fields as default.
  Press the Pick/Edit Lines button and select the 5 units of Cerveza Ale of
  the previously created Sales Order.
  Complete the record.
- Go to the Sales Invoice window and create a new record with
  "Alimentos y Supermercados, S.A" as Business Partner, leaving
  the rest of the fields as default.
  Press the Create Lines From Shipment and select the 5 units of Cerveza Ale of
  the previously created Sales Order.
  Complete the record.
- Go back to the Return from Customer window and press the Close button. Select
  the Reactivate option.
- Press the Insert Orphan Line button and select "Bebida Energética 0,5L" as product
  and 2 units as Returned.
- Press the Pick/Edit Line button and deselect the Orphan Line just created.

#In this moment the modified code is executed (properly working) and no error is thrown#