Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043715Retail ModulesReturn Receiptpublic2020-04-09 08:122020-05-14 18:42
ReporterAgatheBertin 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043715: Returning a verify return , we can still click on the apply button
DescriptionEven if a product is fully returned, we can still click on the apply button
Steps To Reproduce1 - Do a standard ticket A with 1 product
2 - Return this ticket (verified return #1) and checkout
3 - Try to make a verified return (a second one) of the ticket A

Even if the "Apply" button seems to be unavailable, we can click on it anyway
When you click, the product is added to the receipt
Proposed Solution
Additional Information
TagsNOR
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-04-09 08:12AgatheBertinNew Issue
2020-04-09 08:12AgatheBertinAssigned To => Retail
2020-04-09 08:12AgatheBertinTriggers an Emergency Pack => No
2020-04-15 08:44AgatheBertinResolution time => 1588024800
2020-04-16 07:52ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-04-16 10:54rafarodaTag Attached: NOR
2020-04-16 10:54rafarodaIssue Monitored: rafaroda
2020-04-24 10:06hgbotCheckin
2020-04-24 10:06hgbotNote Added: 0119385
2020-04-24 10:06hgbotStatusnew => resolved
2020-04-24 10:06hgbotResolutionopen => fixed
2020-04-24 10:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e5c807b0a6f346718bed32e2e394832600a10078 [^]
2020-04-24 10:07hgbotCheckin
2020-04-24 10:07hgbotNote Added: 0119386
2020-04-27 09:00marvintmReview Assigned To => marvintm
2020-04-27 09:00marvintmStatusresolved => closed
2020-04-27 09:00marvintmFixed in Version => RR20Q3
2020-04-28 05:09ranjith_qualiantech_comNote Added: 0119447
2020-04-28 05:09ranjith_qualiantech_comStatusclosed => new
2020-04-28 05:09ranjith_qualiantech_comResolutionfixed => open
2020-04-28 05:09ranjith_qualiantech_comFixed in VersionRR20Q3 =>
2020-04-28 13:54hgbotCheckin
2020-04-28 13:54hgbotNote Added: 0119471
2020-04-28 13:55hgbotCheckin
2020-04-28 13:55hgbotNote Added: 0119472
2020-04-29 04:57ranjith_qualiantech_comNote Edited: 0119447bug_revision_view_page.php?bugnote_id=0119447#r20909
2020-04-29 05:47ranjith_qualiantech_comStatusnew => scheduled
2020-04-29 05:47ranjith_qualiantech_comStatusscheduled => resolved
2020-04-29 05:47ranjith_qualiantech_comResolutionopen => fixed
2020-04-30 15:46marvintmStatusresolved => closed
2020-04-30 15:46marvintmFixed in Version => RR20Q3
2020-05-13 07:06ranjith_qualiantech_comNote Added: 0119790
2020-05-13 07:06ranjith_qualiantech_comStatusclosed => new
2020-05-13 07:06ranjith_qualiantech_comResolutionfixed => open
2020-05-13 07:06ranjith_qualiantech_comFixed in VersionRR20Q3 =>
2020-05-13 07:06ranjith_qualiantech_comStatusnew => scheduled
2020-05-13 07:31hgbotCheckin
2020-05-13 07:31hgbotNote Added: 0119792
2020-05-13 07:33hgbotCheckin
2020-05-13 07:33hgbotNote Added: 0119793
2020-05-13 07:33ranjith_qualiantech_comStatusscheduled => resolved
2020-05-13 07:33ranjith_qualiantech_comResolutionopen => fixed
2020-05-14 18:42marvintmStatusresolved => closed
2020-05-14 18:42marvintmFixed in Version => RR20Q3

Notes
(0119385)
hgbot   
2020-04-24 10:06   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e5c807b0a6f346718bed32e2e394832600a10078
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Apr 24 13:35:51 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e5c807b0a6f346718bed32e2e394832600a10078 [^]

Fixed issue-43715 : Button tab event should be prevented if it is disabled

* All button inherits from OB.UI.BaseButton.
  If the button is disabled, then tap event should be prevented

---
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
---
(0119386)
hgbot   
2020-04-24 10:07   
Repository: tools/automation/pi-mobile
Changeset: 4af22be2270241c41c79b5fcc269d2d933413301
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Apr 24 13:37:05 2020 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/4af22be2270241c41c79b5fcc269d2d933413301 [^]

Verifies issue 43715 : Modified Automated tests

* Modified Automated tests by new changes in tap event

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/crossstore/CrossStoreTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/crossstore/CrossStoreUISelectStore.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34608_VerifyNoErrorAfterTicketDelete.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/taxes/TaxesBasedOnStoreAddress.java
---
(0119447)
ranjith_qualiantech_com   
2020-04-28 05:09   
(edited on: 2020-04-29 04:57)
Button More, Switch, Coins in Payment keyboard are not working
(0119471)
hgbot   
2020-04-28 13:54   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9f2bf0d9822e814a16e4ac4a3828dafe1b684150
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Apr 28 17:24:37 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9f2bf0d9822e814a16e4ac4a3828dafe1b684150 [^]

Related to issue 43715 : Added tap event for More and Switch button in Payment keyboard

* Added tap event for Coins Button in Payment keyboard

---
M web/org.openbravo.retail.posterminal/js/components/keypadcoins.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---
(0119472)
hgbot   
2020-04-28 13:55   
Repository: tools/automation/pi-mobile
Changeset: 5cb2e883a0b62a30e705964f3aa2663462196e37
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Apr 28 17:24:51 2020 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5cb2e883a0b62a30e705964f3aa2663462196e37 [^]

Verifies issue 43715 : Modified Automated Test I35778_VerifyPayOpenTicketPayments

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31673_CancelLayawayCheckOverPayment.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35778_VerifyPayOpenTicketPayments.java
---
(0119790)
ranjith_qualiantech_com   
2020-05-13 07:06   
For Tap events in Action Button of Edit Tab, Event propagation should be allowed
And also, Sender value should be sent as param for ontap event
(0119792)
hgbot   
2020-05-13 07:31   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 00c899c87a63dc2b196e0f6d54e2a8e16116f556
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed May 13 11:01:17 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/00c899c87a63dc2b196e0f6d54e2a8e16116f556 [^]

Related to issue-43715 : Allow Tap Event Propagation for Buttons based on flag

* Added flag allowTapEventPropagation with default value as false for OB.UI.Button
  If it is true, Tap Event Propagation will be allowed
* Added "this" params for tap and ontap events

---
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
---
(0119793)
hgbot   
2020-05-13 07:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 887f14a8f6ed354349e7294f48a42423de1f63d0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed May 13 11:03:19 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/887f14a8f6ed354349e7294f48a42423de1f63d0 [^]

Related to issue-43715 : Action Button in Edit tab should allow Tap Event Propagation

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
---