Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043687Openbravo ERPA. Platformpublic2020-04-07 09:422020-05-04 07:59
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043687: TranslationHandler does not cancel on first exception and makes more transactions
DescriptionCode in TranslationHandler does not cancel on first exception and makes new transactions afterwards.

So all the rest of the same file and/or module fails with 'transaction is aborted...', not showing if there are additional errors/failures.

It should instead rollback + make a new transaction directly after the error to continue with the next line inside the same file.

a.) Better in case more errors are present per file (to show all of them directly)
b.) Better user-experience as not skipping import of unrelated translations (in the same file after the failing row)
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0043272 closed cberner When importing translation for no longer existing elements -> INFO message is missing all necessary details 
related to defect 0043881 new Triage Platform Base Errors in TranslationHandler should be made accessible to its caller 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-04-07 09:42cbernerNew Issue
2020-04-07 09:42cbernerAssigned To => platform
2020-04-07 09:42cbernerModules => Core
2020-04-07 09:42cbernerTriggers an Emergency Pack => No
2020-04-07 09:42cbernerRelationship addedrelated to 0043272
2020-04-20 14:20shuehnerDescription Updatedbug_revision_view_page.php?rev_id=20814#r20814
2020-04-21 18:24cbernerAssigned Toplatform => cberner
2020-04-21 18:24cbernerStatusnew => scheduled
2020-04-22 18:23cbernerNote Added: 0119342
2020-04-22 18:23cbernerReview Assigned To => alostale
2020-04-27 10:40hgbotCheckin
2020-04-27 10:40hgbotNote Added: 0119410
2020-04-27 10:40hgbotStatusscheduled => resolved
2020-04-27 10:40hgbotResolutionopen => fixed
2020-04-27 10:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5b6b064ba51e51a0b49a4fb82d6ee6addad01a0b [^]
2020-04-27 15:49AtulOpenbravoRelationship addedrelated to 0043881
2020-05-04 07:59alostaleStatusresolved => closed
2020-05-04 07:59alostaleFixed in Version => 3.0PR20Q3

Notes
(0119342)
cberner   
2020-04-22 18:23   
Merge request: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/64 [^]
(0119410)
hgbot   
2020-04-27 10:40   
Repository: erp/devel/pi
Changeset: 5b6b064ba51e51a0b49a4fb82d6ee6addad01a0b
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Tue Apr 21 18:14:07 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5b6b064ba51e51a0b49a4fb82d6ee6addad01a0b [^]

Fixes ISSUE-43687: Cancel and make new transaction on error in TranslationHandl

---
M src/org/openbravo/erpCommon/ad_forms/TranslationHandler.java
M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
---