Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043669ModulesOMSpublic2020-04-06 09:302020-05-19 16:39
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043669: No OMS Configuration message defined in wrong module
DescriptionIf some configuration is still not defined or missing, the OBOMSOC_NoOMSConfiguration message is thrown in the code.
This message is defined in the module "OMS Order Confirmation" instead of "Order Management System (OMS)", where it actually belongs.
Steps To Reproduce-
Proposed Solution1. Delete the message from OMS Order Confirmation module.
2. Create the message in Order Management System (OMS) module.
3. Modify the java implemmentation in Order Management System (OMS) module to add the organization name to the message during execution time.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-04-06 09:30inigo_lergaNew Issue
2020-04-06 09:30inigo_lergaAssigned To => inigo_lerga
2020-04-07 11:02inigo_lergaStatusnew => scheduled
2020-04-07 12:14inigo_lergaNote Added: 0119047
2020-04-23 17:12inigo_lergaNote Edited: 0119047bug_revision_view_page.php?bugnote_id=0119047#r20867
2020-04-23 17:15inigo_lergaSummaryOBOMSOC_NoOMSConfiguration message not defined => No OMS Configuration message defined in wrong module
2020-04-23 17:15inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20869#r20869
2020-04-23 17:15inigo_lergaProposed Solution updated
2020-05-19 16:34hgbotCheckin
2020-05-19 16:34hgbotNote Added: 0120056
2020-05-19 16:34hgbotCheckin
2020-05-19 16:34hgbotNote Added: 0120057
2020-05-19 16:38vmromanosNote Edited: 0120056bug_revision_view_page.php?bugnote_id=0120056#r21067
2020-05-19 16:38vmromanosStatusscheduled => resolved
2020-05-19 16:38vmromanosResolutionopen => fixed
2020-05-19 16:39vmromanosReview Assigned To => vmromanos
2020-05-19 16:39vmromanosNote Added: 0120059
2020-05-19 16:39vmromanosStatusresolved => closed

Notes
(0119047)
inigo_lerga   
2020-04-07 12:14   
(edited on: 2020-04-23 17:12)
--Test Plan Mantis--
Beforehand, the environment needs to have the api generated
and NO OMS configuration setup.
  - Enter the OMS Web Service API
  - Select oms1.1.0
  - Press the Authorize button and Log in with
    Openbravo - openbravo as usual.
  - Open the OMS Web Service POST section (the green one)
  - Press the Try it out button
  - Select any example in the Examples selector
  - Execute the example
#In this moment the error message (filled with the Organization name in use without a OMS configuration) will be thrown as response#
(0120056)
hgbot   
2020-05-19 16:34   
(edited on: 2020-05-19 16:38)
Repository: erp/pmods/org.openbravo.retail.oms.orderconfirmation
Changeset: 91cde272ecc9
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Apr 24 10:11:18 2020 +0200
URL: https://code.openbravo.com/erp/pmods/org.openbravo.oms/rev/91cde272ecc9 [^]

fixes BUG 43669:Added correct message No OMS Config

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/oms/engine/OMSEngine.java
---
(0120057)
hgbot   
2020-05-19 16:34   
Repository: erp/pmods/org.openbravo.retail.oms.orderconfirmation
Changeset: 854da45378a3942e521816b347458323e7660528
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Apr 23 17:07:58 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.oms.orderconfirmation/rev/854da45378a3942e521816b347458323e7660528 [^]

related to ISSUE-43669: Removed message which belongs to OMS module

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0120059)
vmromanos   
2020-05-19 16:39   
Code review + testing OK