Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043668ModulesOMSpublic2020-04-06 09:242020-05-19 16:36
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043668: Ticket definition in Swagger does not fit POJOs definition
DescriptionThe problem resides in the Swagger ticket definition, as it does not fit POJOs definition. Therefore, the infrastructure in java does not know how to fill the warehouses' information. The current definition is as follows:

    "includedWarehouses": [
      {
        "warehouse": {
          "id": "B2D40D8A5D644DD89E329DC297309055",
          "_identifier": "España Región Norte"
        }
      }
    ],
    "excludedWarehouses": [
      {
        "warehouse": {
          "id": "5848641D712545C7AE0FE9634A163648",
          "_identifier": "España Región Sur"
        }
      }
    ]
  
In other words, each warehouse list's object has a 'warehouse' property that does not exist in the java's definition of the ticket. Moreover, the Warehouse java definition does not have a 'warehouse' property either.
Steps To Reproduce-
Proposed SolutionTo stick to the current definition, the info should be articulated with the following structure:

    "includedWarehouses": [
      {
          "id": "B2D40D8A5D644DD89E329DC297309055",
          "_identifier": "España Región Norte",
          "searchKey": "RN"
      }
    ],
    "excludedWarehouses": [
      {
          "id": "5848641D712545C7AE0FE9634A163648",
          "_identifier": "España Región Sur",
          "searchKey": "RS"
      }
    ]
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-04-06 09:24inigo_lergaNew Issue
2020-04-06 09:24inigo_lergaAssigned To => inigo_lerga
2020-04-06 14:02inigo_lergaStatusnew => scheduled
2020-04-07 10:58inigo_lergaNote Added: 0119030
2020-04-24 12:12inigo_lergaNote Edited: 0119030bug_revision_view_page.php?bugnote_id=0119030#r20873
2020-04-24 12:12inigo_lergaNote Edited: 0119030bug_revision_view_page.php?bugnote_id=0119030#r20874
2020-05-19 16:34hgbotCheckin
2020-05-19 16:34hgbotNote Added: 0120055
2020-05-19 16:34hgbotStatusscheduled => resolved
2020-05-19 16:34hgbotResolutionopen => fixed
2020-05-19 16:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.oms/rev/e84f66129b5d4d18754a6e2df9039dfe9f9b9bb1 [^]
2020-05-19 16:36vmromanosReview Assigned To => vmromanos
2020-05-19 16:36vmromanosNote Added: 0120058
2020-05-19 16:36vmromanosStatusresolved => closed

Notes
(0119030)
inigo_lerga   
2020-04-07 10:58   
(edited on: 2020-04-24 12:12)
--Test Plan Mantis--
Beforehand, the environment needs to have the api generated
and an OMS configuration setup.
  - Enter the OMS Web Service API
  - Select oms1.1.0
  - Press the Authorize button and Log in with
    Openbravo - openbravo as usual.
  - Open the OMS Web Service POST section (the green one)
  - Press the Try it out button
  - Select the "Ticket with several lines identified by id and/or searchKey,
    including and excluding warehouses" in the Examples selector
  - Execute the example

#In this moment the modified ticket is executed#

To see the result of the execution of the ticket:
  - In the Backend, go to the OMS Run window.
  - Open the record corresponding to the most recent execution and observe the
    included and excluded warehouses are correctly displayed in the Included
    and Excluded Tabs. The Status of the Header shows the result of execution
    of the ticket.
(0120055)
hgbot   
2020-05-19 16:34   
Repository: erp/pmods/org.openbravo.oms
Changeset: e84f66129b5d4d18754a6e2df9039dfe9f9b9bb1
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri Apr 24 12:29:50 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.oms/rev/e84f66129b5d4d18754a6e2df9039dfe9f9b9bb1 [^]

fixes BUG-43668:Corrected Ticket definition in Swagger

---
M api/org.openbravo.oms-oms1.1.0.yml
---
(0120058)
vmromanos   
2020-05-19 16:36   
Code review + testing OK