Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043642Openbravo ERPA. Platformpublic2020-04-02 08:122020-05-26 17:53
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043642: warnings compiling with Eclipse 2020-03
DescriptionCompiling Openbravo with Eclipse 2020-03 (ecj-4.15) using default Openbravo preferences produces some warnings.
Steps To ReproduceCompile with Eclipse 2020-03 (in this case base retail pack):
     [java] ----------
     [java] 1. WARNING in /home/alostale/ws/base/ob-pg/openbravo/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java 
(at line 140)
     [java] 	BufferedReader reader = new BufferedReader(new InputStreamReader(is, "UTF-8"));
     
[java] 	               ^^^^^^
     [java] Resource leak: 'reader' is never closed
     [java] ----------
     [java] ----------
     [java] 2. WARNING in /home/alostale/ws/base/ob-pg/openbravo/modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/master/ProductProperty.java 
(at line 18)
     [java] 	import org.openbravo.retail.posterminal.master.Product;
     [java] 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     [java] The import org.openbravo.retail.posterminal.master.Product is never used
     [java] ----------
     [java] ----------
     [java] 3. WARNING in /home/alostale/ws/base/ob-pg/openbravo/modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/process/HasDeliveryServices.java 
(at line 19)
     [java] 	import org.openbravo.retail.posterminal.process.HasServices;
     [java] 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     [java] The import org.openbravo.retail.posterminal.process.HasServices is never used
     [java] ----------
     [java] ----------
     [java] 4. WARNING in /home/alostale/ws/base/ob-pg/openbravo/src-test/src/org/openbravo/test/webservice/BaseWSTest.java 
(at line 257)
     [java] 	BufferedReader reader = new BufferedReader(new InputStreamReader(is, "UTF-8"));
     
[java] 	               ^^^^^^
     [java] Resource leak: 'reader' is never closed
     [java] ----------
     [java] ----------
     [java] 5. WARNING in /home/alostale/ws/base/ob-pg/openbravo/src-test/src/org/openbravo/test/webservice/JSONWebServices.java 
(at line 134)
     [java] 	BufferedReader reader = new BufferedReader(new InputStreamReader(is, "UTF-8"));
     
[java] 	               ^^^^^^
     [java] Resource leak: 'reader' is never closed
     [java] ----------
     [java] 5 problems (5 warnings)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0031477 new shuehner Tracking issue to reduce the huge number of eclipse warnings in pi 
depends on backport 00441983.0PR20Q1.2 closed cberner warnings compiling with Eclipse 2020-03 
depends on backport 00441993.0PR20Q2 closed cberner warnings compiling with Eclipse 2020-03 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-04-02 08:12alostaleNew Issue
2020-04-02 08:12alostaleAssigned To => platform
2020-04-02 08:12alostaleOBNetwork customer => No
2020-04-02 08:12alostaleModules => Core
2020-04-02 08:12alostaleTriggers an Emergency Pack => No
2020-04-02 08:13alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20670#r20670
2020-04-02 08:13alostaleRelationship addedrelated to 0031477
2020-04-09 12:43hgbotCheckin
2020-04-09 12:43hgbotNote Added: 0119115
2020-04-09 12:43hgbotStatusnew => resolved
2020-04-09 12:43hgbotResolutionopen => fixed
2020-04-09 12:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9183a11dc6232d73444eec61d31782d9545ff5fa [^]
2020-04-09 12:53alostaleAssigned Toplatform => alostale
2020-04-09 12:54hgbotCheckin
2020-04-09 12:54hgbotNote Added: 0119117
2020-04-09 12:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/9183a11dc6232d73444eec61d31782d9545ff5fa [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d1ff9c46d55949f1cb24fa3a3c681b06ce77d5ba [^]
2020-04-09 12:55alostaleReview Assigned To => caristu
2020-04-13 08:50hgbotCheckin
2020-04-13 08:50hgbotNote Added: 0119122
2020-04-13 08:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d1ff9c46d55949f1cb24fa3a3c681b06ce77d5ba [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/45b9f63744d14062789a9cafec313ea2daa0c754 [^]
2020-04-17 10:17hgbotCheckin
2020-04-17 10:17hgbotNote Added: 0119231
2020-04-17 10:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/45b9f63744d14062789a9cafec313ea2daa0c754 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.amazon.s3/rev/82f1fdaa22628f04d302b9ba3e7d5eda89bc67e8 [^]
2020-04-17 10:19hgbotCheckin
2020-04-17 10:19hgbotNote Added: 0119232
2020-04-17 10:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.service.integration.amazon.s3/rev/82f1fdaa22628f04d302b9ba3e7d5eda89bc67e8 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.magento.core/rev/00e2e7697d7aa77e9f6861ce54b2407b8168ca89 [^]
2020-04-17 10:31caristuNote Added: 0119233
2020-04-17 10:31caristuStatusresolved => closed
2020-04-17 10:31caristuFixed in Version => 3.0PR20Q3
2020-05-26 17:51cbernerStatusclosed => new
2020-05-26 17:51cbernerResolutionfixed => open
2020-05-26 17:51cbernerFixed in Version3.0PR20Q3 =>
2020-05-26 17:52cbernerStatusnew => scheduled
2020-05-26 17:52cbernerAssigned Toalostale => cberner
2020-05-26 17:52cbernerAssigned Tocberner => alostale
2020-05-26 17:53cbernerStatusscheduled => resolved
2020-05-26 17:53cbernerFixed in Version => 3.0PR20Q3
2020-05-26 17:53cbernerResolutionopen => fixed
2020-05-26 17:53cbernerStatusresolved => closed

Notes
(0119115)
hgbot   
2020-04-09 12:43   
Repository: erp/devel/pi
Changeset: 9183a11dc6232d73444eec61d31782d9545ff5fa
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Apr 03 13:43:26 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9183a11dc6232d73444eec61d31782d9545ff5fa [^]

fixed ISSUE-43642: fixes some eclipse warns

---
M src-test/src/org/openbravo/test/webservice/BaseWSTest.java
M src-test/src/org/openbravo/test/webservice/JSONWebServices.java
---
(0119117)
hgbot   
2020-04-09 12:54   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d1ff9c46d55949f1cb24fa3a3c681b06ce77d5ba
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 09 12:53:33 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d1ff9c46d55949f1cb24fa3a3c681b06ce77d5ba [^]

fixed ISSUE-43642: fixes some eclipse warns

---
M src/org/openbravo/retail/posterminal/master/ProductProperty.java
M src/org/openbravo/retail/posterminal/process/HasDeliveryServices.java
---
(0119122)
hgbot   
2020-04-13 08:50   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 45b9f63744d14062789a9cafec313ea2daa0c754
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Apr 13 08:50:07 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/45b9f63744d14062789a9cafec313ea2daa0c754 [^]

fixed ISSUE-43642: fixes some eclipse warns

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
---
(0119231)
hgbot   
2020-04-17 10:17   
Repository: erp/pmods/org.openbravo.service.integration.amazon.s3
Changeset: 82f1fdaa22628f04d302b9ba3e7d5eda89bc67e8
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Apr 17 10:17:36 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.amazon.s3/rev/82f1fdaa22628f04d302b9ba3e7d5eda89bc67e8 [^]

fixed ISSUE-43642: fixes some eclipse warns

---
M src/org/openbravo/service/integration/amazon/s3/AmazonS3Client.java
---
(0119232)
hgbot   
2020-04-17 10:19   
Repository: erp/pmods/org.openbravo.service.integration.magento.core
Changeset: 00e2e7697d7aa77e9f6861ce54b2407b8168ca89
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Apr 17 10:19:33 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.magento.core/rev/00e2e7697d7aa77e9f6861ce54b2407b8168ca89 [^]

fixed ISSUE-43642: fixes some eclipse warns

---
M src-test/org/openbravo/service/integration/magento/core/export/MagentoEndpointBuilderTest.java
---
(0119233)
caristu   
2020-04-17 10:31   
Reviewed

MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/56 [^]