Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043635Retail ModulesDiscounts by Totalpublic2020-04-01 16:232020-04-08 19:14
ReporterLeyre 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelPre packaging ( pi )
Regression date2019-12-26
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/07f46ffd4cc19880c156db43666fe51078495aa7 [^]
Triggers an Emergency PackNo
Summary0043635: The Variable Discounts per Total do not work if amount/percentage is not defined.
DescriptionThe Variable Discounts per Total do not work if amount/percentage is not defined.
Steps To ReproduceBACKEND:
1. With advanced discounts engine and old discounts engine:
Preference "Web POS Use advanced discounts engine" = Y and N
2. Define a "Variable Discount per Total Amount" and do not define the amount.

WEB POS:
1. Add a product.
2. Try adding the previous discount: add the amount manually and add it to the line.
-> Verify that the discount can not be applied. See attached image error_discounts_amount.png

The same example for the discounts "Variable Percentage Discount per Total Amount". See attached image error_discounts_percentage.png
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0042630 closed rqueralta Variable Percentage Discount per Total Amount uses hidden percentage discount as default percentage 
related to defect 0044404 closed ranjith_qualiantech_com Crash when we try to use a promotion with a particular promotion Type 
Attached Filespng error_discounts_amount.png (381,778) 2020-04-01 16:23
https://issues.openbravo.com/file_download.php?file_id=14249&type=bug
png error_discounts_percentage.png (370,956) 2020-04-01 16:23
https://issues.openbravo.com/file_download.php?file_id=14250&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-04-01 16:23LeyreNew Issue
2020-04-01 16:23LeyreAssigned To => Retail
2020-04-01 16:23LeyreFile Added: error_discounts_amount.png
2020-04-01 16:23LeyreResolution time => 1586296800
2020-04-01 16:23LeyreTriggers an Emergency Pack => No
2020-04-01 16:23LeyreFile Added: error_discounts_percentage.png
2020-04-01 16:25LeyreSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20665#r20665
2020-04-01 17:35LeyreSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20668#r20668
2020-04-07 07:29ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-04-07 08:02prakashmurugesan88Assigned Toranjith_qualiantech_com => prakashmurugesan88
2020-04-07 08:02prakashmurugesan88Statusnew => scheduled
2020-04-07 08:24ranjith_qualiantech_comAssigned Toprakashmurugesan88 => ranjith_qualiantech_com
2020-04-07 08:50ranjith_qualiantech_comRelationship addedcaused by 0042630
2020-04-07 08:52ranjith_qualiantech_comRegression level => Pre packaging ( pi )
2020-04-07 08:52ranjith_qualiantech_comRegression date => 2019-12-26
2020-04-07 08:52ranjith_qualiantech_comRegression introduced in release => main
2020-04-07 08:52ranjith_qualiantech_comRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/07f46ffd4cc19880c156db43666fe51078495aa7 [^]
2020-04-07 09:02hgbotCheckin
2020-04-07 09:02hgbotNote Added: 0119013
2020-04-07 09:17hgbotCheckin
2020-04-07 09:17hgbotNote Added: 0119019
2020-04-08 12:19ranjith_qualiantech_comStatusscheduled => resolved
2020-04-08 12:19ranjith_qualiantech_comResolutionopen => fixed
2020-04-08 19:14guilleaerReview Assigned To => guilleaer
2020-04-08 19:14guilleaerStatusresolved => closed
2020-04-08 19:14guilleaerFixed in Version => RR20Q3
2020-07-03 07:43ranjith_qualiantech_comRelationship addedrelated to 0044404

Notes
(0119013)
hgbot   
2020-04-07 09:02   
Repository: erp/pmods/org.openbravo.retail.discounts.category
Changeset: 2ddc229edfff3c060340851f591d000bc38aa261
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Apr 07 12:29:39 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.category/rev/2ddc229edfff3c060340851f591d000bc38aa261 [^]

Related to issue 43635 : Updated discount property if amount is changed for Variable discounts

---
M web/org.openbravo.retail.discounts.category/js/discountsButton.js
---
(0119019)
hgbot   
2020-04-07 09:17   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 8fadaa8a1bc2872f48bf805020ca0f8473ca0240
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Apr 07 12:47:43 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/8fadaa8a1bc2872f48bf805020ca0f8473ca0240 [^]

Related to issue 43635 : User amount should be used for Variable discount calculation

---
M web/org.openbravo.retail.discounts.bytotal/js/discountsengine/common/rules/by-total-amount-discount.js
---