Openbravo Issue Tracking System - Retail Modules
View Issue Details
0043617Retail ModulesSend By Emailpublic2020-03-31 12:262021-08-23 09:37
salvador_campanella 
salvador_campanella 
normalmajoralways
closedunable to reproduce 
5
RR20Q1 
 
No
0043617: org.openbravo.retail.sendemail module fails compiling
org.openbravo.retail.sendemail module fails compiling
- In a local environment 20Q1 with retails modules

-copy the module in the modules folder
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail [^]

- Execute the command "ant smartbuild -Dlocal=no"


Result
compileSqlc:
    [javac] Compiling 3 source files to /home/openbravo/OBenvironments/ob_3_0pr20q1_15420/build/classes
    [javac] /home/openbravo/OBenvironments/ob_3_0pr20q1_15420/modules/org.openbravo.retail.sendemail/src/org/openbravo/retail/sendemail/sync/OBSMAIL_ErrorHandler.java:29: error: OBSMAIL_ErrorHandler is not abstract and does not override abstract method handleError(Throwable,Entity,JSONObject,JSONObject) in DataSynchronizationErrorHandler
    [javac] public class OBSMAIL_ErrorHandler extends DataSynchronizationErrorHandler {
    [javac] ^
    [javac] /home/openbravo/OBenvironments/ob_3_0pr20q1_15420/modules/org.openbravo.retail.sendemail/src/org/openbravo/retail/sendemail/sync/OBSMAIL_ErrorHandler.java:32: error: method does not override or implement a method from a supertype
    [javac] @Override
    [javac] ^
    [javac] 2 errors

BUILD FAILED
/home/openbravo/OBenvironments/ob_3_0pr20q1_15420/build.xml:420: The following error occurred while executing this line:
/home/openbravo/OBenvironments/ob_3_0pr20q1_15420/src/build.xml:575: The following error occurred while executing this line:
/home/openbravo/OBenvironments/ob_3_0pr20q1_15420/src/build.xml:251: Compile failed; see the compiler error output for details.
No tags attached.
Issue History
2020-03-31 12:26salvador_campanellaNew Issue
2020-03-31 12:26salvador_campanellaAssigned To => Retail
2020-03-31 12:26salvador_campanellaResolution time => 1587420000
2020-03-31 12:26salvador_campanellaTriggers an Emergency Pack => No
2020-03-31 13:08PracticsIssue Monitored: Practics
2020-04-08 08:02prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-04-08 08:25prakashmurugesan88Statusnew => scheduled
2020-04-08 11:48prakashmurugesan88Assigned Toprakashmurugesan88 => guilleaer
2020-04-08 13:09prakashmurugesan88Assigned Toguilleaer => prakashmurugesan88
2020-04-08 17:32salvador_campanellaversionpi => RR20Q1
2020-04-08 17:32salvador_campanellaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20740#r20740
2020-04-17 14:46guilleaerAssigned Toprakashmurugesan88 => salvador_campanella
2020-04-17 14:46guilleaerStatusscheduled => feedback
2021-08-09 14:54plujanNote Added: 0131042
2021-08-23 09:37marvintmStatusfeedback => closed
2021-08-23 09:37marvintmResolutionopen => unable to reproduce

Notes
(0131042)
plujan   
2021-08-09 14:54   
Comment from the developer:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/commit/8e1efba8594727bfe97ec9bc34dd50d5cf01f404 [^]

-- public void handleError(final Throwable exception, final Entity entity, final JSONObject result, final JSONObject jsonRecord) {

++ public void handleError(final Throwable exception, final String typeOfData, final JSONObject result, final JSONObject jsonRecord) {

From above 2 commits I can guess the following,
As per commit handleError(Throwable,Entity,JSONObject,JSONObject) is old function.
It is updated to new function handleError(Throwable,String,JSONObject,JSONObject).

So I think the user gave build by updating sendemail module upto date where the handleError 2nd param is String(New Function). But he missed to updated mobile core module where the handleError 2nd param is Entity (Old Function). Therefore the error occurs.