Openbravo Issue Tracking System - Modules
View Issue Details
0043598ModulesAdvance Warehouse Operationspublic2020-03-26 15:392020-05-14 18:29
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
 
dmiguelez
0043598: Apply new HQL Style in TaskEventObserver.java
TaskEventObserver.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged platform Openbravo ERP Tracking issue: Convert HQL to apply new style 
Issue History
2020-03-26 15:39inigo_lergaNew Issue
2020-03-26 15:39inigo_lergaAssigned To => inigo_lerga
2020-03-26 15:39inigo_lergaRelationship addedrelated to 0041287
2020-03-26 15:39inigo_lergaStatusnew => scheduled
2020-03-26 16:25inigo_lergaNote Added: 0118848
2020-05-14 18:29hgbotCheckin
2020-05-14 18:29hgbotNote Added: 0119895
2020-05-14 18:29hgbotStatusscheduled => resolved
2020-05-14 18:29hgbotResolutionopen => fixed
2020-05-14 18:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/d3768906e840f484a5e4bb839220cf625dbdd4e8 [^]
2020-05-14 18:29dmiguelezReview Assigned To => dmiguelez
2020-05-14 18:29dmiguelezNote Added: 0119896
2020-05-14 18:29dmiguelezStatusresolved => closed

Notes
(0118848)
inigo_lerga   
2020-03-26 16:25   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQL is updated#
(0119895)
hgbot   
2020-05-14 18:29   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: d3768906e840f484a5e4bb839220cf625dbdd4e8
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Mar 26 16:23:38 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/d3768906e840f484a5e4bb839220cf625dbdd4e8 [^]

fixes BUG-43598:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/eventobserver/TaskEventObserver.java
---
(0119896)
dmiguelez   
2020-05-14 18:29   
Code Review + Testing Ok