Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043597ModulesAdvanced Warehouse Operationspublic2020-03-26 15:082020-05-14 17:47
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043597: Apply new HQL Style in InternalRoutingAssiEventObserver.java
DescriptionInternalRoutingAssiEventObserver.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-26 15:08inigo_lergaNew Issue
2020-03-26 15:08inigo_lergaAssigned To => inigo_lerga
2020-03-26 15:08inigo_lergaRelationship addedrelated to 0041287
2020-03-26 15:08inigo_lergaStatusnew => scheduled
2020-03-26 15:38inigo_lergaNote Added: 0118847
2020-05-14 17:46hgbotCheckin
2020-05-14 17:46hgbotNote Added: 0119892
2020-05-14 17:46hgbotStatusscheduled => resolved
2020-05-14 17:46hgbotResolutionopen => fixed
2020-05-14 17:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/6080d9a2956e9c4f95a098ac4c6593a3a70dbe11 [^]
2020-05-14 17:47dmiguelezReview Assigned To => dmiguelez
2020-05-14 17:47dmiguelezNote Added: 0119893
2020-05-14 17:47dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0118847)
inigo_lerga   
2020-03-26 15:38   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQL is updated#
(0119892)
hgbot   
2020-05-14 17:46   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 6080d9a2956e9c4f95a098ac4c6593a3a70dbe11
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Mar 26 15:31:34 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/6080d9a2956e9c4f95a098ac4c6593a3a70dbe11 [^]

fixes BUG-43597:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/eventobserver/InternalRoutingAssiEventObserver.java
---
(0119893)
dmiguelez   
2020-05-14 17:47   
Code Review + Testing Ok