Openbravo Issue Tracking System - Modules
View Issue Details
0043595ModulesAdvance Warehouse Operationspublic2020-03-26 14:112020-05-14 16:01
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
 
dmiguelez
0043595: Apply new HQL Style in InventoryTransactionTypeAlgorithm.java
InventoryTransactionTypeAlgorithm.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged platform Openbravo ERP Tracking issue: Convert HQL to apply new style 
Issue History
2020-03-26 14:11inigo_lergaNew Issue
2020-03-26 14:11inigo_lergaAssigned To => inigo_lerga
2020-03-26 14:12inigo_lergaRelationship addedrelated to 0041287
2020-03-26 14:12inigo_lergaStatusnew => scheduled
2020-03-26 14:14inigo_lergaSummaryApply new HQL Style in InternalMovementGenerator.java => Apply new HQL Style in InventoryTransactionTypeAlgorithm.java
2020-03-26 14:14inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20636#r20636
2020-03-26 14:30inigo_lergaNote Added: 0118843
2020-05-14 16:00hgbotCheckin
2020-05-14 16:00hgbotNote Added: 0119887
2020-05-14 16:00hgbotStatusscheduled => resolved
2020-05-14 16:00hgbotResolutionopen => fixed
2020-05-14 16:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0616f4488cf5e01abb65a50896757c098654b8dd [^]
2020-05-14 16:01dmiguelezReview Assigned To => dmiguelez
2020-05-14 16:01dmiguelezNote Added: 0119888
2020-05-14 16:01dmiguelezStatusresolved => closed

Notes
(0118843)
inigo_lerga   
2020-03-26 14:30   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQL is updated#
(0119887)
hgbot   
2020-05-14 16:00   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 0616f4488cf5e01abb65a50896757c098654b8dd
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Mar 26 14:34:14 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0616f4488cf5e01abb65a50896757c098654b8dd [^]

fixes BUG-43595:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/InventoryTransactionTypeAlgorithm.java
---
(0119888)
dmiguelez   
2020-05-14 16:01   
Code Review + Testing Ok