Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043593ModulesAdvanced Warehouse Operationspublic2020-03-26 13:312020-05-13 10:55
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043593: Apply new HQL Style in GroupOfTasksValidator.java
DescriptionGroupOfTasksValidator.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-26 13:31inigo_lergaNew Issue
2020-03-26 13:31inigo_lergaAssigned To => inigo_lerga
2020-03-26 13:31inigo_lergaRelationship addedrelated to 0041287
2020-03-26 13:32inigo_lergaStatusnew => scheduled
2020-03-26 13:56inigo_lergaNote Added: 0118838
2020-05-13 10:54hgbotCheckin
2020-05-13 10:54hgbotNote Added: 0119803
2020-05-13 10:54hgbotStatusscheduled => resolved
2020-05-13 10:54hgbotResolutionopen => fixed
2020-05-13 10:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/3425d9490729d92c0d8057b78818a835fc373549 [^]
2020-05-13 10:54hgbotCheckin
2020-05-13 10:54hgbotNote Added: 0119804
2020-05-13 10:55dmiguelezReview Assigned To => dmiguelez
2020-05-13 10:55dmiguelezNote Added: 0119805
2020-05-13 10:55dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0118838)
inigo_lerga   
2020-03-26 13:56   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQL is updated#
(0119803)
hgbot   
2020-05-13 10:54   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 3425d9490729d92c0d8057b78818a835fc373549
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Mar 26 13:54:05 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/3425d9490729d92c0d8057b78818a835fc373549 [^]

fixes BUG-43593:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/GroupOfTasksValidator.java
---
(0119804)
hgbot   
2020-05-13 10:54   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 392eb0ac099fb26198b583fbdcfd7d70c533b8a5
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed May 13 10:54:37 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/392eb0ac099fb26198b583fbdcfd7d70c533b8a5 [^]

Related to ISSUE-43593. Renamed hql parameter

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/GroupOfTasksValidator.java
---
(0119805)
dmiguelez   
2020-05-13 10:55   
Code Review + Testing Ok