Openbravo Issue Tracking System - Modules
View Issue Details
0043589ModulesAdvanced Warehouse Operationspublic2020-03-26 12:282020-05-12 18:45
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
 
dmiguelez
0043589: Apply new HQL Style in RecalculateOccupancyProcess.java
RecalculateOccupancyProcess.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Issue History
2020-03-26 12:28inigo_lergaNew Issue
2020-03-26 12:28inigo_lergaAssigned To => inigo_lerga
2020-03-26 12:28inigo_lergaStatusnew => scheduled
2020-03-26 12:28inigo_lergaRelationship addedrelated to 0041287
2020-03-26 13:10inigo_lergaNote Added: 0118834
2020-05-12 18:44hgbotCheckin
2020-05-12 18:44hgbotNote Added: 0119786
2020-05-12 18:44hgbotStatusscheduled => resolved
2020-05-12 18:44hgbotResolutionopen => fixed
2020-05-12 18:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/35fbebaba3e09bf91721266f3cc674544d62aeb0 [^]
2020-05-12 18:45dmiguelezReview Assigned To => dmiguelez
2020-05-12 18:45dmiguelezNote Added: 0119787
2020-05-12 18:45dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0118834)
inigo_lerga   
2020-03-26 13:10   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
As the AWO-QA Admin - AWO-QA role:
  - Go to the Process Request window and create a new
    record. Leave every field as default except Process,
    put "Recalculate Storage bin Occupancy" in it.
  - Press the Schedule Process button.

  #In this moment the modified HQL is updated#
(0119786)
hgbot   
2020-05-12 18:44   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 35fbebaba3e09bf91721266f3cc674544d62aeb0
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Mar 26 13:06:29 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/35fbebaba3e09bf91721266f3cc674544d62aeb0 [^]

fixes BUG-43589:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ad_process/RecalculateOccupancyProcess.java
---
(0119787)
dmiguelez   
2020-05-12 18:45   
Code Review + Testing Ok