Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043580Retail ModulesWeb POSpublic2020-03-25 18:012020-03-26 14:12
Reportershuehner 
Assigned Toguilleaer 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR20Q2Fixed in VersionRR20Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043580: Apply new HQL style in CrossStoreInfoProperties
Description1. Avoid use of StringBuilder use normal Strings.
2. HQL formatting is important for improving readability.
3. Avoid use of Property Constant if any

In this specific file this is about the 'address' StringBuilder() which ends up as executable HQL via HQLProperty

Apart of removing the StringBuilder reformatting the HQL text should improve readability quite a bit
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Filesdiff diffIssue43580.diff (1,954) 2020-03-25 18:24
https://issues.openbravo.com/file_download.php?file_id=14215&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-03-25 18:01shuehnerNew Issue
2020-03-25 18:01shuehnerAssigned To => Retail
2020-03-25 18:01shuehnerOBNetwork customer => No
2020-03-25 18:01shuehnerTriggers an Emergency Pack => No
2020-03-25 18:01shuehnerRelationship addedrelated to 0041287
2020-03-25 18:02shuehnerTarget Version => RR20Q2
2020-03-25 18:24guilleaerFile Added: diffIssue43580.diff
2020-03-26 09:18hgbotCheckin
2020-03-26 09:18hgbotNote Added: 0118829
2020-03-26 09:18hgbotStatusnew => resolved
2020-03-26 09:18hgbotResolutionopen => fixed
2020-03-26 09:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/535da87eeb8211f17852cec1589d2ed49019f2c3 [^]
2020-03-26 09:58marvintmAssigned ToRetail => guilleaer
2020-03-26 14:12marvintmReview Assigned To => marvintm
2020-03-26 14:12marvintmStatusresolved => closed
2020-03-26 14:12marvintmFixed in Version => RR20Q2

Notes
(0118829)
hgbot   
2020-03-26 09:18   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 535da87eeb8211f17852cec1589d2ed49019f2c3
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Mar 26 09:18:28 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/535da87eeb8211f17852cec1589d2ed49019f2c3 [^]

fixed BUG 43580: Change StringBuilder to String and format query

---
M src/org/openbravo/retail/posterminal/master/CrossStoreInfoProperties.java
---