Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0043580 | Retail Modules | Web POS | public | 2020-03-25 18:01 | 2020-03-26 14:12 |
|
| Reporter | shuehner | |
| Assigned To | guilleaer | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | RR20Q2 | Fixed in Version | RR20Q2 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0043580: Apply new HQL style in CrossStoreInfoProperties |
| Description | 1. Avoid use of StringBuilder use normal Strings.
2. HQL formatting is important for improving readability.
3. Avoid use of Property Constant if any
In this specific file this is about the 'address' StringBuilder() which ends up as executable HQL via HQLProperty
Apart of removing the StringBuilder reformatting the HQL text should improve readability quite a bit |
| Steps To Reproduce | - |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | design defect | 0041287 | | acknowledged | Triage Platform Base | Openbravo ERP | Tracking issue: Convert HQL to apply new style |
|
| Attached Files |  diffIssue43580.diff (1,954) 2020-03-25 18:24
https://issues.openbravo.com/file_download.php?file_id=14215&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2020-03-25 18:01 | shuehner | New Issue | |
| 2020-03-25 18:01 | shuehner | Assigned To | => Retail |
| 2020-03-25 18:01 | shuehner | Triggers an Emergency Pack | => No |
| 2020-03-25 18:01 | shuehner | Relationship added | related to 0041287 |
| 2020-03-25 18:02 | shuehner | Target Version | => RR20Q2 |
| 2020-03-25 18:24 | guilleaer | File Added: diffIssue43580.diff | |
| 2020-03-26 09:18 | hgbot | Checkin | |
| 2020-03-26 09:18 | hgbot | Note Added: 0118829 | |
| 2020-03-26 09:18 | hgbot | Status | new => resolved |
| 2020-03-26 09:18 | hgbot | Resolution | open => fixed |
| 2020-03-26 09:18 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/535da87eeb8211f17852cec1589d2ed49019f2c3 [^] |
| 2020-03-26 09:58 | marvintm | Assigned To | Retail => guilleaer |
| 2020-03-26 14:12 | marvintm | Review Assigned To | => marvintm |
| 2020-03-26 14:12 | marvintm | Status | resolved => closed |
| 2020-03-26 14:12 | marvintm | Fixed in Version | => RR20Q2 |