Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0043573Openbravo ERP09. Financial managementpublic2020-03-25 15:162020-04-06 15:50
shuehner 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
3.0PR20Q23.0PR20Q2 
dmiguelez
Core
No
0043573: Apply new HQL style in PriceDifferenceUtil
1. Avoid use of StringBuilder use normal Strings.
2. HQL formatting is important for improving readability.
3. Avoid use of Property Constant if any
-
Follow new style available here http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged platform Tracking issue: Convert HQL to apply new style 
diff 43573_partial.diff (518) 2020-03-25 15:17
https://issues.openbravo.com/file_download.php?file_id=14212&type=bug
Issue History
2020-03-25 15:16shuehnerNew Issue
2020-03-25 15:16shuehnerAssigned To => Triage Finance
2020-03-25 15:16shuehnerModules => Core
2020-03-25 15:16shuehnerTriggers an Emergency Pack => No
2020-03-25 15:16shuehnerRelationship addedrelated to 0041287
2020-03-25 15:17shuehnerFile Added: 43573_partial.diff
2020-03-25 15:19shuehnerNote Added: 0118812
2020-03-26 09:03inigo_lergaAssigned ToTriage Finance => inigo_lerga
2020-03-26 09:03inigo_lergaStatusnew => scheduled
2020-03-26 10:32inigo_lergaNote Added: 0118830
2020-04-01 09:27hgbotCheckin
2020-04-01 09:27hgbotNote Added: 0118898
2020-04-01 09:27hgbotStatusscheduled => resolved
2020-04-01 09:27hgbotResolutionopen => fixed
2020-04-01 09:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ab8c6a4b3c323bb1843ba40e47de13a4292095e2 [^]
2020-04-01 09:28dmiguelezReview Assigned To => dmiguelez
2020-04-01 09:28dmiguelezNote Added: 0118899
2020-04-01 09:28dmiguelezStatusresolved => closed
2020-04-01 09:28dmiguelezFixed in Version => 3.0PR20Q2
2020-04-06 11:54hgbotCheckin
2020-04-06 11:54hgbotNote Added: 0118981
2020-04-06 11:54hgbotStatusclosed => resolved
2020-04-06 11:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/ab8c6a4b3c323bb1843ba40e47de13a4292095e2 [^] => http://code.openbravo.com/erp/devel/pi/rev/420829b2a6d0eaaf0c9be088c484090e49d83c3f [^]
2020-04-06 15:50jarmendarizNote Added: 0118995
2020-04-06 15:50jarmendarizStatusresolved => closed

Notes
(0118812)
shuehner   
2020-03-25 15:19   
That file did use String already to construct HQL query.
However part of that String was creating using String.concat function instead of just doing it using the typical +=

That caused this to come up as non-constant string in automation.

Apart patch fixes that part.

Looking at HQL formatting probably should be reformatted for better readability also.
(0118830)
inigo_lerga   
2020-03-26 10:32   
--Test Plan Mantis HQL--
As the F&B International Group Admin role:
  - Go to the Process Price Difference Adjustment window.
    Select "F&B España, S.A" as Organization and Today's date
    as Movement Date.
    In the Product field select "Cerveza Ale 0,5L".
  - Press the Done button.

  #In this moment the modified HQL is updated#
(0118898)
hgbot   
2020-04-01 09:27   
Repository: erp/devel/pi
Changeset: ab8c6a4b3c323bb1843ba40e47de13a4292095e2
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Mar 26 10:34:28 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ab8c6a4b3c323bb1843ba40e47de13a4292095e2 [^]

fixes BUG-43573:Applied new HQL Style

---
M src/org/openbravo/costing/PriceDifferenceUtil.java
---
(0118899)
dmiguelez   
2020-04-01 09:28   
Code Review + Testing Ok
(0118981)
hgbot   
2020-04-06 11:54   
Repository: erp/devel/pi
Changeset: 420829b2a6d0eaaf0c9be088c484090e49d83c3f
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Mar 26 10:34:28 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/420829b2a6d0eaaf0c9be088c484090e49d83c3f [^]

fixes BUG-43573:Applied new HQL Style

---
M src/org/openbravo/costing/PriceDifferenceUtil.java
---
(0118995)
jarmendariz   
2020-04-06 15:50   
closed: wrongly reopened