Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043572Retail ModulesWeb POSpublic2020-03-25 13:512020-03-26 14:11
Reportershuehner 
Assigned Toguilleaer 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR20Q2Fixed in VersionRR20Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043572: When fixing HQLStyle issues in posterminal 4 cases we not fully fixed
DescriptionThis is follow up to issue 41890 which did not fully fix 4 cases inside posterminal.

While it rewrote creation of HQL from StringBuilder to String it missed to remove the old .toString() call added when using the StringBuilder.

As calling toString() on a String is not useful that should be removed.
Also not having that fixed triggers still false positives with our automation.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041890 closed alekosmp86 Retail Modules StringBuffer/Builder in Retail modules should be replaced by String 
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Filesdiff 43572.diff (3,050) 2020-03-25 13:53
https://issues.openbravo.com/file_download.php?file_id=14210&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-03-25 13:51shuehnerNew Issue
2020-03-25 13:51shuehnerAssigned To => Retail
2020-03-25 13:51shuehnerOBNetwork customer => No
2020-03-25 13:51shuehnerTriggers an Emergency Pack => No
2020-03-25 13:51shuehnerRelationship addedrelated to 0041890
2020-03-25 13:51shuehnerTarget Version => RR20Q2
2020-03-25 13:53shuehnerFile Added: 43572.diff
2020-03-25 13:54shuehnerRelationship addedrelated to 0041287
2020-03-26 09:18hgbotCheckin
2020-03-26 09:18hgbotNote Added: 0118828
2020-03-26 09:18hgbotStatusnew => resolved
2020-03-26 09:18hgbotResolutionopen => fixed
2020-03-26 09:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3de126a19f4c716922e3db91ba0964906f9620be [^]
2020-03-26 09:58marvintmAssigned ToRetail => guilleaer
2020-03-26 14:11marvintmReview Assigned To => marvintm
2020-03-26 14:11marvintmStatusresolved => closed
2020-03-26 14:11marvintmFixed in Version => RR20Q2

Notes
(0118828)
hgbot   
2020-03-26 09:18   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3de126a19f4c716922e3db91ba0964906f9620be
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Mar 25 14:06:40 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3de126a19f4c716922e3db91ba0964906f9620be [^]

fixed BUG 43572: Change StringBuilder to String in some HQL

---
M src/org/openbravo/retail/posterminal/UpdateProductCategoryByAssortmentBackground.java
M src/org/openbravo/retail/posterminal/process/CheckUpdated.java
M src/org/openbravo/retail/posterminal/stock/StoreDetailedStock.java
---