Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043521Retail ModulesDiscounts by Totalpublic2020-03-18 12:302020-04-06 18:49
ReporterLeyre 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerGold
Support ticket15306
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043521: The by total discount is not applied correctly to the receipt lines
DescriptionThe by total discount is not applied correctly to the receipt lines
Steps To ReproduceBackend:
1) Configure a product as non Grouped Product and price = 19.9
2) Configure a Variable Discount per Total Amount with amount = 60
3) Set the "Web POS Use advanced discounts engine" preference = N

Web POS:
1) Add the previous product with quantity = 6
2) Try to add the previous discount

Verify that the discounted amount is not proportional on all lines and is not correct. see the attached image of the tests in livebuilds
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0043322 closed rqueralta The "By Total" discount does not apply correctly the discounted qty. on the receipt lines 
related to defect 0043880 closed ranjith_qualiantech_com Using the old discount engine, the "by total" discount is not calculated correctly on the receipt lines 
Attached Filespng bytotal.png (204,342) 2020-03-18 12:30
https://issues.openbravo.com/file_download.php?file_id=14182&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2020-03-18 12:30LeyreNew Issue
2020-03-18 12:30LeyreAssigned To => Retail
2020-03-18 12:30LeyreFile Added: bytotal.png
2020-03-18 12:30LeyreOBNetwork customer => Gold
2020-03-18 12:30LeyreSupport ticket => 15306
2020-03-18 12:30LeyreResolution time => 1586296800
2020-03-18 12:30LeyreTriggers an Emergency Pack => No
2020-03-18 15:20markmm82Assigned ToRetail => markmm82
2020-03-18 15:26markmm82Statusnew => scheduled
2020-03-20 15:36rqueraltaAssigned Tomarkmm82 => rqueralta
2020-03-23 13:59hgbotCheckin
2020-03-23 13:59hgbotNote Added: 0118758
2020-03-23 13:59hgbotStatusscheduled => resolved
2020-03-23 13:59hgbotResolutionopen => fixed
2020-03-23 13:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/c8fc8d26ecce97474164381d1ef3365a0979997f [^]
2020-03-25 16:44jorge-garciaReview Assigned To => jorge-garcia
2020-03-26 08:47jorge-garciaNote Added: 0118827
2020-03-26 08:47jorge-garciaStatusresolved => closed
2020-03-26 08:47jorge-garciaFixed in Version => RR20Q2
2020-04-06 18:49ngarciaRelationship addedcaused by 0043322
2020-04-27 13:42LeyreRelationship addedrelated to 0043880

Notes
(0118758)
hgbot   
2020-03-23 13:59   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: c8fc8d26ecce97474164381d1ef3365a0979997f
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Fri Mar 20 14:04:56 2020 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/c8fc8d26ecce97474164381d1ef3365a0979997f [^]

Fixed BUG-43521: The by total discount is not applied correctly to the receipt
lines

- The old discount execute twice in By total discount rule. Now before apply
this discount we check if this discount rule is already apply to the line

---
M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js
---
(0118827)
jorge-garcia   
2020-03-26 08:47   
Code reviewed and tested