Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043515Openbravo ERPA. Platformpublic2020-03-17 16:302020-04-06 15:50
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043515: Apply new HQL Style in ReplaceOrderExecutor.java
DescriptionReplaceOrderExecutor.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-17 16:30inigo_lergaNew Issue
2020-03-17 16:30inigo_lergaAssigned To => inigo_lerga
2020-03-17 16:30inigo_lergaModules => Core
2020-03-17 16:30inigo_lergaTriggers an Emergency Pack => No
2020-03-17 16:32inigo_lergaRelationship addedrelated to 0041287
2020-03-17 16:32inigo_lergaStatusnew => scheduled
2020-03-18 10:03inigo_lergaNote Added: 0118667
2020-03-20 13:14hgbotCheckin
2020-03-20 13:14hgbotNote Added: 0118711
2020-03-20 13:14hgbotStatusscheduled => resolved
2020-03-20 13:14hgbotResolutionopen => fixed
2020-03-20 13:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dd468d7cebe3e8cb1c57a778708ab3c40ed6c8ae [^]
2020-03-20 13:14hgbotCheckin
2020-03-20 13:14hgbotNote Added: 0118712
2020-03-20 13:15dmiguelezReview Assigned To => dmiguelez
2020-03-20 13:15dmiguelezNote Added: 0118713
2020-03-20 13:15dmiguelezStatusresolved => closed
2020-03-20 13:15dmiguelezFixed in Version => 3.0PR20Q2
2020-04-06 11:53hgbotCheckin
2020-04-06 11:53hgbotNote Added: 0118971
2020-04-06 11:53hgbotStatusclosed => resolved
2020-04-06 11:53hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/dd468d7cebe3e8cb1c57a778708ab3c40ed6c8ae [^] => http://code.openbravo.com/erp/devel/pi/rev/cc2ce00b64cba67fa26c5fc5220e2e6914118ef1 [^]
2020-04-06 11:53hgbotCheckin
2020-04-06 11:53hgbotNote Added: 0118972
2020-04-06 15:50jarmendarizNote Added: 0118993
2020-04-06 15:50jarmendarizStatusresolved => closed

Notes
(0118667)
inigo_lerga   
2020-03-18 10:03   
--Test Plan Mantis HQL--
For this query to get executed, the preference
"Enable Cancel and Replace" needs to be active beforehand.
As the F&B International Group Admin role:
  - Go to the Sales Order window and create a new record
    with any Business Partner desired.
  - Go to the Lines Tab and create a new Line with any product
    desired.
  - Press the Book button and OK in the popup window.
  - Press the Cancel and Replace button and Done in the popup
    window.
  - Press the Confirm Cancel and Replace button and Done in the
    popup window.

  #In this moment the modified HQL query is executed.#
(0118711)
hgbot   
2020-03-20 13:14   
Repository: erp/devel/pi
Changeset: dd468d7cebe3e8cb1c57a778708ab3c40ed6c8ae
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Mar 18 10:17:23 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/dd468d7cebe3e8cb1c57a778708ab3c40ed6c8ae [^]

fixes BUG-43515:Applied new HQL Style

---
M src/org/openbravo/erpCommon/businessUtility/ReplaceOrderExecutor.java
---
(0118712)
hgbot   
2020-03-20 13:14   
Repository: erp/devel/pi
Changeset: a0e22318efdccedd929e589e372efa9c8d49e410
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Mar 18 12:44:02 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a0e22318efdccedd929e589e372efa9c8d49e410 [^]

related to ISSUE-43515: Finals added & more

- Finals added
- PROPERTY_ strings replaced by actual strings
- Copyright updated

---
M src/org/openbravo/erpCommon/businessUtility/ReplaceOrderExecutor.java
---
(0118713)
dmiguelez   
2020-03-20 13:15   
Code Review + Testing Ok
(0118971)
hgbot   
2020-04-06 11:53   
Repository: erp/devel/pi
Changeset: cc2ce00b64cba67fa26c5fc5220e2e6914118ef1
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Mar 18 10:17:23 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cc2ce00b64cba67fa26c5fc5220e2e6914118ef1 [^]

fixes BUG-43515:Applied new HQL Style

---
M src/org/openbravo/erpCommon/businessUtility/ReplaceOrderExecutor.java
---
(0118972)
hgbot   
2020-04-06 11:53   
Repository: erp/devel/pi
Changeset: 905628ab507352842154b09c2cd519d9b46d2a8d
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Mar 18 12:44:02 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/905628ab507352842154b09c2cd519d9b46d2a8d [^]

related to ISSUE-43515: Finals added & more

- Finals added
- PROPERTY_ strings replaced by actual strings
- Copyright updated

---
M src/org/openbravo/erpCommon/businessUtility/ReplaceOrderExecutor.java
---
(0118993)
jarmendariz   
2020-04-06 15:50   
closed: wrongly reopened