Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043509Openbravo ERPA. Platformpublic2020-03-17 12:592020-04-06 15:48
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043509: Apply new HQL Style in CreateReplacementOrderExecutor.java
DescriptionCreateReplacementOrderExecutor.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-17 12:59inigo_lergaNew Issue
2020-03-17 12:59inigo_lergaAssigned To => inigo_lerga
2020-03-17 12:59inigo_lergaModules => Core
2020-03-17 12:59inigo_lergaTriggers an Emergency Pack => No
2020-03-17 12:59inigo_lergaStatusnew => scheduled
2020-03-17 16:27inigo_lergaNote Added: 0118647
2020-03-17 16:28inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20572#r20572
2020-03-17 16:31inigo_lergaRelationship addedrelated to 0041287
2020-03-20 13:02hgbotCheckin
2020-03-20 13:02hgbotNote Added: 0118705
2020-03-20 13:02hgbotStatusscheduled => resolved
2020-03-20 13:02hgbotResolutionopen => fixed
2020-03-20 13:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7d7d80ad9ca52ca5d4a7b35ad4439cb2bb224497 [^]
2020-03-20 13:02hgbotCheckin
2020-03-20 13:02hgbotNote Added: 0118706
2020-03-20 13:03dmiguelezReview Assigned To => dmiguelez
2020-03-20 13:03dmiguelezNote Added: 0118707
2020-03-20 13:03dmiguelezStatusresolved => closed
2020-03-20 13:03dmiguelezFixed in Version => 3.0PR20Q2
2020-04-06 11:53hgbotCheckin
2020-04-06 11:53hgbotNote Added: 0118969
2020-04-06 11:53hgbotStatusclosed => resolved
2020-04-06 11:53hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/7d7d80ad9ca52ca5d4a7b35ad4439cb2bb224497 [^] => http://code.openbravo.com/erp/devel/pi/rev/007beaf8b4cee258a7a83cf2021f7255000d1716 [^]
2020-04-06 11:53hgbotCheckin
2020-04-06 11:53hgbotNote Added: 0118970
2020-04-06 15:48jarmendarizNote Added: 0118991
2020-04-06 15:48jarmendarizStatusresolved => closed

Notes
(0118647)
inigo_lerga   
2020-03-17 16:27   
--Test Plan Mantis HQL--
For this query to get executed, the preference
"Enable Cancel and Replace" needs to be active beforehand.
As the F&B International Group Admin role:
  - Go to the Sales Order window and create a new record
    with any Business Partner desired.
  - Go to the Lines Tab and create a new Line with any product
    desired.
  - Press the Book button and OK in the popup window.
  - Press the Cancel and Replace button and Done in the popup
    window.

  #In this moment the modified HQL query is executed.#
(0118705)
hgbot   
2020-03-20 13:02   
Repository: erp/devel/pi
Changeset: 7d7d80ad9ca52ca5d4a7b35ad4439cb2bb224497
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 17 14:51:08 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7d7d80ad9ca52ca5d4a7b35ad4439cb2bb224497 [^]

fixes BUG-43509:Applied new HQL Style

---
M src/org/openbravo/erpCommon/businessUtility/CreateReplacementOrderExecutor.java
---
(0118706)
hgbot   
2020-03-20 13:02   
Repository: erp/devel/pi
Changeset: b2006d53219c59f956103971ec03f12321dc9f54
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 17 15:28:27 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b2006d53219c59f956103971ec03f12321dc9f54 [^]

related to ISSUE-43509: Finals added

-Finals added

---
M src/org/openbravo/erpCommon/businessUtility/CreateReplacementOrderExecutor.java
---
(0118707)
dmiguelez   
2020-03-20 13:03   
Code Review + Testing Ok
(0118969)
hgbot   
2020-04-06 11:53   
Repository: erp/devel/pi
Changeset: 007beaf8b4cee258a7a83cf2021f7255000d1716
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 17 14:51:08 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/007beaf8b4cee258a7a83cf2021f7255000d1716 [^]

fixes BUG-43509:Applied new HQL Style

---
M src/org/openbravo/erpCommon/businessUtility/CreateReplacementOrderExecutor.java
---
(0118970)
hgbot   
2020-04-06 11:53   
Repository: erp/devel/pi
Changeset: d6ea067482c804fd92516685de98e7b0bd2ad96a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 17 15:28:27 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d6ea067482c804fd92516685de98e7b0bd2ad96a [^]

related to ISSUE-43509: Finals added

-Finals added

---
M src/org/openbravo/erpCommon/businessUtility/CreateReplacementOrderExecutor.java
---
(0118991)
jarmendariz   
2020-04-06 15:48   
closed: wrongly reopened