Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043507Retail ModulesWeb POSpublic2020-03-17 09:472020-03-27 06:53
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043507: Remove winston npm dependency from mobile.core
DescriptionThe winston[1] npm library was added to provide to the jest based test infrastructure the ability to log information.

It seems that this does not provide so much value because:

- When enabled there is information logged that is not very useful. For that reason it is disabled by default.

- When creating/analyzing a test, it is possible to debug it using an IDE (VisualStudio, IntelliJ, etc.)

[1] https://www.npmjs.com/package/winston [^]
Steps To Reproduce.
Proposed SolutionDelete winston npm dependency
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0043288 closed marvintm Implement StateController and SynchronizationBuffer components using IndexedDB 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-17 09:47caristuNew Issue
2020-03-17 09:47caristuAssigned To => Retail
2020-03-17 09:47caristuOBNetwork customer => No
2020-03-17 09:47caristuTriggers an Emergency Pack => No
2020-03-17 09:47caristuAssigned ToRetail => caristu
2020-03-17 09:48caristuDescription Updatedbug_revision_view_page.php?rev_id=20570#r20570
2020-03-23 08:38alostaleRelationship addedrelated to 0043288
2020-03-23 08:42caristuNote Added: 0118743
2020-03-24 10:58hgbotCheckin
2020-03-24 10:58hgbotNote Added: 0118783
2020-03-24 10:58hgbotStatusnew => resolved
2020-03-24 10:58hgbotResolutionopen => fixed
2020-03-24 10:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f71b8966f3cf81039fe7b81a8c8424e33c28b118 [^]
2020-03-24 10:59caristuReview Assigned To => alostale
2020-03-27 06:53alostaleStatusresolved => closed
2020-03-27 06:53alostaleFixed in Version => RR20Q2

Notes
(0118743)
caristu   
2020-03-23 08:42   
MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/10 [^]
(0118783)
hgbot   
2020-03-24 10:58   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f71b8966f3cf81039fe7b81a8c8424e33c28b118
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Sat Mar 21 18:04:30 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f71b8966f3cf81039fe7b81a8c8424e33c28b118 [^]

fixes BUG-43507: Remove winston npm dependency

  Remove winston npm dependency and log infrastructure from the JS tests since it is not being very used

---
M package.json
M web-test/base/adapter.js
M web-test/base/ob-app.js
R web-test/base/log.js
---