Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043481Retail ModulesWeb POSpublic2020-03-12 13:172020-09-23 21:30
Reporterjavietxe 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043481: Order Error Deleting Lines With SUPR key
DescriptionWhile deleting the lines using the supr key of the keyboard repeatedly, the deleted lines are duplicated and it makes the order fail while importing it from the POS.
Steps To ReproduceEnable "Use External input" for the Touchpoint Type.

Set the "Web POS Save Removed Tickets" preference to Y.


- Add at least 10 items in your basket
- repeatedly (quickly) press "Supr" button, you can see a part of your items deleted
- pay the ticket
- go to the back office, you can see an error in "Errors while importing"

Video link :
https://drive.google.com/file/d/1uBaJAHjUU-GvDAcxJR9WhNkG8VxaMzY8/view [^] [^]
Proposed SolutionSet a scrim while deleting the line to avoid having more than one deleted line for the same line
Additional Information
TagsNOR
Relationships
related to defect 0044773 closed ranjith_qualiantech_com Delete Ticket does not wait for the CalculateReceipt execution 
related to defect 0055002 closed Rajesh_18 Error when trying to change line quantity after deleting an order 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-12 13:17javietxeNew Issue
2020-03-12 13:17javietxeAssigned To => Retail
2020-03-12 13:17javietxeResolution time => 1585778400
2020-03-12 13:17javietxeTriggers an Emergency Pack => No
2020-03-18 15:21markmm82Assigned ToRetail => markmm82
2020-03-20 18:46markmm82Statusnew => scheduled
2020-03-28 16:59markmm82File Added: 43481.patch
2020-04-02 10:08guilleaerNote Added: 0118915
2020-04-02 10:11ranjith_qualiantech_comAssigned Tomarkmm82 => ranjith_qualiantech_com
2020-04-07 09:29ranjith_qualiantech_comFile Added: issue 43481 source posterminal.patch
2020-04-07 12:04ranjith_qualiantech_comFile Deleted: 43481.patch
2020-04-13 10:12hgbotCheckin
2020-04-13 10:12hgbotNote Added: 0119130
2020-04-13 10:12hgbotStatusscheduled => resolved
2020-04-13 10:12hgbotResolutionopen => fixed
2020-04-13 10:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/45f2181b5ffd5c351aaee29e7cba57963f2c30b8 [^]
2020-04-14 02:41hgbotCheckin
2020-04-14 02:41hgbotNote Added: 0119140
2020-04-14 13:24migueldejuanaStatusresolved => new
2020-04-14 13:24migueldejuanaResolutionfixed => open
2020-04-14 13:24migueldejuanaStatusnew => scheduled
2020-04-15 09:16ranjith_qualiantech_comFile Deleted: issue 43481 source posterminal.patch
2020-04-24 10:07hgbotCheckin
2020-04-24 10:07hgbotNote Added: 0119387
2020-04-24 10:07hgbotStatusscheduled => resolved
2020-04-24 10:07hgbotResolutionopen => fixed
2020-04-24 10:07hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/45f2181b5ffd5c351aaee29e7cba57963f2c30b8 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c17c79a0d71dd4a16d3dd2651d56f0c831f5bdac [^]
2020-04-26 16:55hgbotCheckin
2020-04-26 16:55hgbotNote Added: 0119404
2020-04-26 16:55hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c17c79a0d71dd4a16d3dd2651d56f0c831f5bdac [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4d7e3b8fd18ba4e8211bc43ade0e75ba0c0bbc9b [^]
2020-04-27 11:37guilleaerReview Assigned To => guilleaer
2020-04-27 11:37guilleaerStatusresolved => closed
2020-04-27 11:37guilleaerFixed in Version => RR20Q3
2020-09-23 15:46ngarciaRelationship addedrelated to 0044773
2020-09-23 21:30rafarodaTag Attached: NOR
2024-03-20 00:45ivazquezRelationship addedrelated to 0055002

Notes
(0118915)
guilleaer   
2020-04-02 10:08   
Attached patch is failing in try-retail
(0119130)
hgbot   
2020-04-13 10:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 45f2181b5ffd5c351aaee29e7cba57963f2c30b8
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Apr 13 13:42:05 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/45f2181b5ffd5c351aaee29e7cba57963f2c30b8 [^]

Fixes issue 43481 : Refactored ProcessController when deleting receipt lines

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0119140)
hgbot   
2020-04-14 02:41   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 19f655cab07e2890c9aef868c98c2dc568ceeacc
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Apr 14 06:11:08 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/19f655cab07e2890c9aef868c98c2dc568ceeacc [^]

Related to issue-43481 : Backed out changeset: 45f2181b5ffd

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0119387)
hgbot   
2020-04-24 10:07   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c17c79a0d71dd4a16d3dd2651d56f0c831f5bdac
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Apr 24 13:26:52 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c17c79a0d71dd4a16d3dd2651d56f0c831f5bdac [^]

Fixed issue-43481 : Command event should be prevented if continuosly triggered

* When '+' or '-' command is called, based on the line qty,
  qty may increased or decreased or deleted.
  if this command is continuosly triggered,
  process should be prevented before completing the previous one
* Lines should be validated with receipt lines

---
M web/org.openbravo.retail.posterminal/js/actions/changequantity.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0119404)
hgbot   
2020-04-26 16:55   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4d7e3b8fd18ba4e8211bc43ade0e75ba0c0bbc9b
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sun Apr 26 20:25:44 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4d7e3b8fd18ba4e8211bc43ade0e75ba0c0bbc9b [^]

Fixed issue-43481 : Added Callback for receipt checkReturnableProducts

* When Plus and Minus command event triggered,
  Callback should be called for all cases either validation success or failure

---
M web/org.openbravo.retail.posterminal/js/actions/changequantity.js
M web/org.openbravo.retail.posterminal/js/actions/returnline.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---