Openbravo Issue Tracking System - Modules
View Issue Details
0043480ModulesAdvance Warehouse Operationspublic2020-03-12 12:462020-03-30 17:52
santi_lozano 
inigo_lerga 
highmajoralways
closedfixed 
5
 
 
dmiguelez
0043480: Confirming task from AWO FE doesn’t fill dimension fields on created document
For example the Dimension field Project of a Goods Receipt is not filled with the data of the corresponding Purchase Order if it has been created after confirming a Receipt Purchase Order task from AWO FE (Advanced Warehouse Operations Front End). Otherwise if you create the Purchase Order with a Project related to it and create the Goods Receipt from Pending Goods Receipt window, it is correctly filled with the corresponding data of the project that appears on the Purchase Order.
Also happens on other similar flows: Sales Order, Return From Customer, Return To Vendor (more cases should be reviewed if there are)
Also happens with other Dimensions not only Project
(seems that this has not been thought on code to copy the corresponding dimensions from AWO FE flow)
* Download Openbravo 19Q3.4 locally, install Openbravo for Retail, Retail SampleData, Advanced Warehouse Operations Pack, Advanced Warehouse Operations Sampledata (rebuild the application and launch ant import.sample.data)
* Change role to AWO-QA Admin, go to Client window, for AWO-QA set on Accounting Dimensions Project to be checked, then also Show in Header and Show in Lines (do the same with role F&B International Group Admin if necessary). This way project field will be shown on Goods Receipt and Purchase Order
http://wiki.openbravo.com/wiki/Client#Dimensions [^]
* Change role to System Admin, select Openbravo for Retail Module, uncheck Apply Configuration Script, compile (this way the window Multiphase Project will appear from the menu, which refers to the project field)
* Change role to AWO-QA Admin, go to Multiphase Project window. Create a new one: Organization = US, Search Key and Name = Project Test, Starting Date = today, Planned End Date = today + 1 month, Business Partner = Milk & More (shown on More Information section)
* Go to window Purchase Order, create a new one: Organization = US West Coast, Business Partner = Milk & More, Warehouse = US West Coast, Project = Project Test
* On Lines tab for that Purchase Order, create a new one: Product = Alouette Creme de Brie, Operative Quantity = 4 (whatever)
* Click on button Book then OK. Then click on button Receive to generate the Task, on popup select user AWO_US_W to be assigned to this task
* Go to AWO Front End, enter with user AWO_US_W, select the task displayed that we have just created, confirm it (a goods receipt has been created for it on backoffice)
* Go back to backoffice, window Goods Receipt, select the one that has been created, check that Project field has not been filled with the project related to the corresponding Purchase Order
* Neither lines
CASE B
You could access now with role F&B International Group Admin, create a Multiphase Project, create a Purchase Order with it, then create the Goods Receipt from window Pending Goods Receipt to see a case in which this Project field is filled correctly with the data of the related Purchase Order
No tags attached.
png 15115 - Dimensions not filled.png (158,003) 2020-03-13 10:41
https://issues.openbravo.com/file_download.php?file_id=14164&type=bug
png

png 15115 - from sales order example.png (106,473) 2020-03-13 12:01
https://issues.openbravo.com/file_download.php?file_id=14168&type=bug
png

png 15115 - other dimension (cost center) example.png (125,170) 2020-03-13 12:10
https://issues.openbravo.com/file_download.php?file_id=14169&type=bug
png
Issue History
2020-03-12 12:46santi_lozanoNew Issue
2020-03-12 12:46santi_lozanoAssigned To => Triage Finance
2020-03-12 12:46santi_lozanoFile Added: 15115 - field not filled after confirming awo fe receipt purchase order task.png
2020-03-12 12:57dmiguelezAssigned ToTriage Finance => inigo_lerga
2020-03-12 14:25eugeniIssue Monitored: eugeni
2020-03-13 10:41santi_lozanoSummaryReceipt Purchase Order task from AWO FE doesn’t fill Project field on Goods Receipt => Task from AWO FE doesn’t fill dimension fields on created document
2020-03-13 10:41santi_lozanoDescription Updatedbug_revision_view_page.php?rev_id=20552#r20552
2020-03-13 10:41santi_lozanoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20554#r20554
2020-03-13 10:41santi_lozanoFile Deleted: 15115 - field not filled after confirming awo fe receipt purchase order task.png
2020-03-13 10:41santi_lozanoFile Added: 15115 - Dimensions not filled.png
2020-03-13 10:42santi_lozanoSummaryTask from AWO FE doesn’t fill dimension fields on created document => Confirming task from AWO FE doesn’t fill dimension fields on created document
2020-03-13 12:01santi_lozanoFile Added: 15115 - from sales order example.png
2020-03-13 12:03santi_lozanoDescription Updatedbug_revision_view_page.php?rev_id=20558#r20558
2020-03-13 12:10santi_lozanoFile Added: 15115 - other dimension (cost center) example.png
2020-03-20 09:21inigo_lergaStatusnew => scheduled
2020-03-24 15:49inigo_lergaNote Added: 0118790
2020-03-30 17:51hgbotCheckin
2020-03-30 17:51hgbotNote Added: 0118881
2020-03-30 17:51hgbotStatusscheduled => resolved
2020-03-30 17:51hgbotResolutionopen => fixed
2020-03-30 17:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/cdd2211c039be6b03904f047df1e473209d72764 [^]
2020-03-30 17:51hgbotCheckin
2020-03-30 17:51hgbotNote Added: 0118882
2020-03-30 17:52dmiguelezReview Assigned To => dmiguelez
2020-03-30 17:52dmiguelezNote Added: 0118883
2020-03-30 17:52dmiguelezStatusresolved => closed

Notes
(0118790)
inigo_lerga   
2020-03-24 15:49   
--Test Plan Mantis--
With AWO installed in an activated Openbravo Instance with both Retail and AWO sampledatas:
As the AWO-QA Admin role in the backoffice:
  - Go to Client window, for AWO-QA set on Accounting Dimensions Project to be checked,
    then also Show in Header and Show in Lines.

As the System Admin role in the backoffice:
  - Select Openbravo for Retail Module, uncheck Apply Configuration Script and compile.

As the AWO-QA Admin role in the backoffice:
  - Go to Multiphase Project window. Create a new one: Organization = US, Search Key
    and Name = Project Test, Starting Date = today, Planned End Date = today + 1 month,
    Business Partner = Milk & More (shown on More Information section).
  - Go to window Purchase Order, create a new one: Organization = US West Coast,
    Business Partner = Milk & More, Warehouse = US West Coast, Project = Project Test
  - Go to the Lines tab for the previous Purchase Order, create a new one:
    Product = Alouette Creme de Brie, Operative Quantity = 4 (whatever)
    Click on button Book then OK. Then click on button Receive to generate the Task,
    on popup select user AWO_US_W to be assigned to this task.

As the AWO_US_W user in AWO Front End:
  - Enter with user AWO_US_W, select the task displayed that we have just created,
    confirm it (a goods receipt has been created for it on backoffice).

As the AWO-QA Admin role in the backoffice:
  - Go back to Goods Receipt window, select the one that has been created,
    check that Project field has been filled with the project related
    to the corresponding Purchase Order.
(0118881)
hgbot   
2020-03-30 17:51   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: cdd2211c039be6b03904f047df1e473209d72764
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 24 14:53:01 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/cdd2211c039be6b03904f047df1e473209d72764 [^]

fixes BUG-43480:Added Dimensions info in Header and Lines

Goods receipts now have the Dimensions info that Purchase
Orders contain, both in the Header and in Lines.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/ShipmentInOutGenerator.java
---
(0118882)
hgbot   
2020-03-30 17:51   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: c1fcceae35b32518007fcc38817798747f96c0e7
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Mar 30 17:51:13 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/c1fcceae35b32518007fcc38817798747f96c0e7 [^]

Related to ISSUE-43480 Code Review Changes:
* Created Order and OrderLine variables instead of indirectly
  referencing them so many times

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/ShipmentInOutGenerator.java
---
(0118883)
dmiguelez   
2020-03-30 17:52   
Code Review + Testing Ok