Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0043475 | Retail Modules | Web POS | public | 2020-03-11 09:12 | 2020-05-25 08:16 |
|
| Reporter | kchoperena | |
| Assigned To | prakashmurugesan88 | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR20Q3 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0043475: Any component that extends OB.UI.Modal and have maxheight defined without bodyParent, fails in WebPOS login |
| Description | The OB.UI.Modal does not have a bodyParent defined. In the initComponents function, there is a code to set the maxheight to the bodyParent but there is no bodyParent present in OB.UI.Modal.
if (this.maxheight) {
//FIXME-SKIN
this.$.bodyParent.setStyle('max-height: ' + this.maxheight + ';');
}
So then, if a new component extends from OB.UI.Modal and have a maxheight but not a bodyParent, the login fails in this code.
Also, in the upgrade to 20Q1 we are not allowing set styles in this way. The correct approach to do that is apply the maxheight using CSS. |
| Steps To Reproduce | 1.- Create a new component that extends from OB.UI.Modal
2.- Define a maxheight but not a bodyParent
3.- Try to do login in the WebPOS |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  maxHeightApplyStyleRemoveOBUIModal.diff (582) 2020-03-11 09:12
https://issues.openbravo.com/file_download.php?file_id=14156&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2020-03-11 09:12 | kchoperena | New Issue | |
| 2020-03-11 09:12 | kchoperena | Assigned To | => Retail |
| 2020-03-11 09:12 | kchoperena | File Added: maxHeightApplyStyleRemoveOBUIModal.diff | |
| 2020-03-11 09:12 | kchoperena | Resolution time | => 1585090800 |
| 2020-03-11 09:12 | kchoperena | Triggers an Emergency Pack | => No |
| 2020-05-05 12:08 | rafademiguel | Priority | normal => high |
| 2020-05-05 16:02 | marvintm | Resolution time | 1585090800 => 1590444000 |
| 2020-05-05 16:02 | marvintm | Type | design defect => defect |
| 2020-05-21 07:24 | prakashmurugesan88 | Assigned To | Retail => prakashmurugesan88 |
| 2020-05-21 07:24 | prakashmurugesan88 | Status | new => scheduled |
| 2020-05-21 12:09 | hgbot | Checkin | |
| 2020-05-21 12:09 | hgbot | Note Added: 0120124 | |
| 2020-05-21 12:09 | hgbot | Status | scheduled => resolved |
| 2020-05-21 12:09 | hgbot | Resolution | open => fixed |
| 2020-05-21 12:09 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d7d9374287533364e3f4cfef216d3b70bb5490f7 [^] |
| 2020-05-25 08:16 | marvintm | Review Assigned To | => marvintm |
| 2020-05-25 08:16 | marvintm | Status | resolved => closed |
| 2020-05-25 08:16 | marvintm | Fixed in Version | => RR20Q3 |