Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043460Retail ModulesWeb POSpublic2020-03-09 14:202020-03-25 15:52
Reporterngarcia 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerGold
Support ticket15163
Regression levelProduction - QA Approved
Regression date2019-12-07
Regression introduced in releaseRR20Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/annotate/2952cba75b5a/web/org.openbravo.retail.posterminal/js/receiptMultiLineEdit.js#l872 [^]
Triggers an Emergency PackNo
Summary0043460: JS error when leaving the Delivery Date empty after changing the Delivery mode of a line
DescriptionJS error when leaving the Delivery Date empty after changing the Delivery mode of a line to

Pickup in store with date
Home Delivery
Steps To ReproduceIn the backoffice:
   Set the Web POS Enable Delivery Modes preference to Y

In the POS:
   Add a line
   Change the Delivery Mode to "Pickup in store with date"
   Do not set a Delivery Date
   Apply
   
   The following error is shown in the browser:
      TypeError: dateSelected.toDateString is not a function at Object.applyChanges...

   The same problem happens with Home Delivery
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0043575RR20Q1.1 closed ranjith_qualiantech_com JS error when leaving the Delivery Date empty after changing the Delivery mode of a line 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-09 14:20ngarciaNew Issue
2020-03-09 14:20ngarciaAssigned To => Retail
2020-03-09 14:20ngarciaOBNetwork customer => Gold
2020-03-09 14:20ngarciaSupport ticket => 15163
2020-03-09 14:20ngarciaResolution time => 1585519200
2020-03-09 14:20ngarciaTriggers an Emergency Pack => No
2020-03-09 14:21ngarciaDescription Updatedbug_revision_view_page.php?rev_id=20527#r20527
2020-03-09 14:21ngarciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=20529#r20529
2020-03-18 00:11rqueraltaAssigned ToRetail => rqueralta
2020-03-18 00:12rqueraltaStatusnew => scheduled
2020-03-19 16:44hgbotCheckin
2020-03-19 16:44hgbotNote Added: 0118689
2020-03-19 16:44hgbotStatusscheduled => resolved
2020-03-19 16:44hgbotResolutionopen => fixed
2020-03-19 16:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/602fbdb28a745a76464f47376bba1825a4e7ccba [^]
2020-03-25 15:15jorge-garciaReview Assigned To => jorge-garcia
2020-03-25 15:51jorge-garciaRegression level => Production - QA Approved
2020-03-25 15:51jorge-garciaRegression date => 2019-12-07
2020-03-25 15:51jorge-garciaRegression introduced in release => RR20Q1
2020-03-25 15:51jorge-garciaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/annotate/2952cba75b5a/web/org.openbravo.retail.posterminal/js/receiptMultiLineEdit.js#l872 [^]
2020-03-25 15:52jorge-garciaNote Added: 0118814
2020-03-25 15:52jorge-garciaStatusresolved => new
2020-03-25 15:52jorge-garciaResolutionfixed => open
2020-03-25 15:52jorge-garciaStatusnew => scheduled
2020-03-25 15:52jorge-garciaStatusscheduled => resolved
2020-03-25 15:52jorge-garciaFixed in Version => RR20Q2
2020-03-25 15:52jorge-garciaResolutionopen => fixed
2020-03-25 15:52jorge-garciaNote Added: 0118815
2020-03-25 15:52jorge-garciaStatusresolved => closed

Notes
(0118689)
hgbot   
2020-03-19 16:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 602fbdb28a745a76464f47376bba1825a4e7ccba
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Mar 18 17:18:04 2020 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/602fbdb28a745a76464f47376bba1825a4e7ccba [^]

Fixed BUG-43460: JS error when leaving the Delivery Date empty after changing
the Delivery mode of a line

- Check if date is empty too

---
M web/org.openbravo.retail.posterminal/js/receiptEdit.js
M web/org.openbravo.retail.posterminal/js/receiptMultiLineEdit.js
---
(0118814)
jorge-garcia   
2020-03-25 15:52   
Re-schedule issue to create backport
(0118815)
jorge-garcia   
2020-03-25 15:52   
Code reviewed and tested