Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043458Openbravo ERPA. Platformpublic2020-03-09 13:472020-03-11 18:51
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043458: Apply new HQL Style in ResetValuedStockAggregated.java
DescriptionResetValuedStockAggregated.java has five HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-09 13:47inigo_lergaNew Issue
2020-03-09 13:47inigo_lergaAssigned To => inigo_lerga
2020-03-09 13:47inigo_lergaModules => Core
2020-03-09 13:47inigo_lergaTriggers an Emergency Pack => No
2020-03-09 13:52inigo_lergaRelationship addedrelated to 0041287
2020-03-09 13:52inigo_lergaStatusnew => scheduled
2020-03-10 09:53inigo_lergaNote Added: 0118456
2020-03-11 18:50hgbotCheckin
2020-03-11 18:50hgbotNote Added: 0118536
2020-03-11 18:50hgbotStatusscheduled => resolved
2020-03-11 18:50hgbotResolutionopen => fixed
2020-03-11 18:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/18f65bdd0309754e7f94f4dc1dd5537bbb5b6bc9 [^]
2020-03-11 18:50hgbotCheckin
2020-03-11 18:50hgbotNote Added: 0118537
2020-03-11 18:51dmiguelezReview Assigned To => dmiguelez
2020-03-11 18:51dmiguelezNote Added: 0118538
2020-03-11 18:51dmiguelezStatusresolved => closed
2020-03-11 18:51dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118456)
inigo_lerga   
2020-03-10 09:53   
--Test Plan Mantis HQL queries--
As the System Administrator role:
  - Go to the Menu window and search for "Reset Valued Stock Aggregate"
    window record. Open it and set the record as Active (You will need
    to set its Module as in Development).
Log out and Log in again.

As the F&B International Group Admin role:
  - Go to the Reset Valued Stock Aggregate window, select any organization
    in the Invoice Organization field and press the Done button.

  #In this moment the modified HQLs are executed#
(0118536)
hgbot   
2020-03-11 18:50   
Repository: erp/devel/pi
Changeset: 18f65bdd0309754e7f94f4dc1dd5537bbb5b6bc9
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 10 10:00:05 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/18f65bdd0309754e7f94f4dc1dd5537bbb5b6bc9 [^]

fixes BUG-43458:Applied new HQL Style

---
M src/org/openbravo/materialmgmt/ResetValuedStockAggregated.java
---
(0118537)
hgbot   
2020-03-11 18:50   
Repository: erp/devel/pi
Changeset: d4ce843d6f00d6db75ccd9f5f85a6e18e6dfa16b
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 10 10:13:32 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d4ce843d6f00d6db75ccd9f5f85a6e18e6dfa16b [^]

related to ISSUE-43458: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied
-Small refactor in code

---
M src/org/openbravo/materialmgmt/ResetValuedStockAggregated.java
---
(0118538)
dmiguelez   
2020-03-11 18:51   
Code Review + Testing Ok