Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043453Openbravo ERPA. Platformpublic2020-03-09 11:272020-03-11 18:09
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043453: Apply new HQL Style in ReservationUtils.java
DescriptionReservationUtils.java has two HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-09 11:27inigo_lergaNew Issue
2020-03-09 11:27inigo_lergaAssigned To => inigo_lerga
2020-03-09 11:27inigo_lergaModules => Core
2020-03-09 11:27inigo_lergaTriggers an Emergency Pack => No
2020-03-09 11:27inigo_lergaRelationship addedrelated to 0041287
2020-03-09 11:27inigo_lergaStatusnew => scheduled
2020-03-09 16:23inigo_lergaNote Added: 0118428
2020-03-11 18:08hgbotCheckin
2020-03-11 18:08hgbotNote Added: 0118530
2020-03-11 18:08hgbotStatusscheduled => resolved
2020-03-11 18:08hgbotResolutionopen => fixed
2020-03-11 18:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5220437cfeadfb842c02644d49f7812ac94fe4c3 [^]
2020-03-11 18:08hgbotCheckin
2020-03-11 18:08hgbotNote Added: 0118531
2020-03-11 18:08hgbotCheckin
2020-03-11 18:08hgbotNote Added: 0118532
2020-03-11 18:09dmiguelezReview Assigned To => dmiguelez
2020-03-11 18:09dmiguelezNote Added: 0118533
2020-03-11 18:09dmiguelezStatusresolved => closed
2020-03-11 18:09dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118428)
inigo_lerga   
2020-03-09 16:23   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Execute the ReferencedInventoryTestSuite.java file.

  #In this moment one of the modified HQLs is executed#

  - Go to the Warehouse and Storage Bins window and enter the
    "F&B España - Región Norte" record.
  - Select the "Rn-0-0-0" Storage Bin. Press the Change Status
    button and choose the "Bloqued" option in the Inventory Status
    selector.
(0118530)
hgbot   
2020-03-11 18:08   
Repository: erp/devel/pi
Changeset: 5220437cfeadfb842c02644d49f7812ac94fe4c3
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Mar 09 16:42:28 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5220437cfeadfb842c02644d49f7812ac94fe4c3 [^]

fixes BUG-43453:Applied new HQL Style

---
M src/org/openbravo/materialmgmt/ReservationUtils.java
---
(0118531)
hgbot   
2020-03-11 18:08   
Repository: erp/devel/pi
Changeset: 2c0e4eb6a5df289e642480cd2e710e1c77d76a93
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Mar 09 16:44:05 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2c0e4eb6a5df289e642480cd2e710e1c77d76a93 [^]

related to ISSUE-43453: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

---
M src/org/openbravo/materialmgmt/ReservationUtils.java
---
(0118532)
hgbot   
2020-03-11 18:08   
Repository: erp/devel/pi
Changeset: dfdffb7bcad7075c3b6e7bd3a4106e2a258e7e36
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Mar 11 18:08:40 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/dfdffb7bcad7075c3b6e7bd3a4106e2a258e7e36 [^]

Related to ISSUE-43453. Code Review changes
* Adds removed throw exception to avoid possible API change

---
M src/org/openbravo/materialmgmt/ReservationUtils.java
---
(0118533)
dmiguelez   
2020-03-11 18:09   
Code Review + Testing Ok