Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0043411Openbravo ERPA. Platformpublic2020-03-04 08:562020-03-11 11:20
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
3.0PR20Q2 
dmiguelez
Core
No
0043411: Apply new HQL Style in FinancialUtils.java
FinancialUtils.java has two HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged platform Tracking issue: Convert HQL to apply new style 
Issue History
2020-03-04 08:56inigo_lergaNew Issue
2020-03-04 08:56inigo_lergaAssigned To => inigo_lerga
2020-03-04 08:56inigo_lergaModules => Core
2020-03-04 08:56inigo_lergaTriggers an Emergency Pack => No
2020-03-04 08:56inigo_lergaRelationship addedrelated to 0041287
2020-03-04 08:57inigo_lergaStatusnew => scheduled
2020-03-04 10:08inigo_lergaNote Added: 0118314
2020-03-11 11:19hgbotCheckin
2020-03-11 11:19hgbotNote Added: 0118503
2020-03-11 11:19hgbotStatusscheduled => resolved
2020-03-11 11:19hgbotResolutionopen => fixed
2020-03-11 11:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5945c28b65c235e44ce9016ba8ce2b41fbf67c76 [^]
2020-03-11 11:19hgbotCheckin
2020-03-11 11:19hgbotNote Added: 0118504
2020-03-11 11:20dmiguelezReview Assigned To => dmiguelez
2020-03-11 11:20dmiguelezNote Added: 0118505
2020-03-11 11:20dmiguelezStatusresolved => closed
2020-03-11 11:20dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118314)
inigo_lerga   
2020-03-04 10:08   
--Test Plan Mantis HQL queries--
For this query to get executed, Execute the TestCosting.java JUnit tests.
#In this moment one of the modified HQLs is executed#

As the F&B International Group Admin role:
  - Go to the Business Partner window and open the
    "Alimentos y Supermercados, S.A" record.
    Press the Set New Currency button.
  
  #In this moment the second modified HQL is executed#
(0118503)
hgbot   
2020-03-11 11:19   
Repository: erp/devel/pi
Changeset: 5945c28b65c235e44ce9016ba8ce2b41fbf67c76
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Mar 04 10:11:28 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5945c28b65c235e44ce9016ba8ce2b41fbf67c76 [^]

fixes BUG-43411:Applied new HQL Style

---
M src/org/openbravo/financial/FinancialUtils.java
---
(0118504)
hgbot   
2020-03-11 11:19   
Repository: erp/devel/pi
Changeset: d04832b1bcf2a7b8775f70c14ff9b6a0ce5c4cff
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Mar 04 10:51:02 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d04832b1bcf2a7b8775f70c14ff9b6a0ce5c4cff [^]

related to ISSUE-43411: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

---
M src/org/openbravo/financial/FinancialUtils.java
---
(0118505)
dmiguelez   
2020-03-11 11:20   
Code Review + Testing Ok