Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043404Openbravo ERPA. Platformpublic2020-03-03 13:502020-03-06 15:07
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043404: Apply new HQL Style in UOMConversionEventHandler.java
DescriptionUOMConversionEventHandler.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-03 13:50inigo_lergaNew Issue
2020-03-03 13:50inigo_lergaAssigned To => inigo_lerga
2020-03-03 13:50inigo_lergaModules => Core
2020-03-03 13:50inigo_lergaTriggers an Emergency Pack => No
2020-03-03 13:50inigo_lergaRelationship addedrelated to 0041287
2020-03-03 13:51inigo_lergaStatusnew => scheduled
2020-03-03 16:46inigo_lergaNote Added: 0118301
2020-03-06 15:06dmiguelezNote Added: 0118405
2020-03-06 15:07hgbotCheckin
2020-03-06 15:07hgbotNote Added: 0118406
2020-03-06 15:07hgbotStatusscheduled => resolved
2020-03-06 15:07hgbotResolutionopen => fixed
2020-03-06 15:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ef59a5ef2626261c33d057be6a7080381f522a90 [^]
2020-03-06 15:07hgbotCheckin
2020-03-06 15:07hgbotNote Added: 0118407
2020-03-06 15:07dmiguelezReview Assigned To => dmiguelez
2020-03-06 15:07dmiguelezNote Added: 0118408
2020-03-06 15:07dmiguelezStatusresolved => closed
2020-03-06 15:07dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118301)
inigo_lerga   
2020-03-03 16:46   
--Test Plan Mantis HQL queries--
For this query to get executed, the preference Enable UOM Management
needs to be activated.
As the F&B International Group Admin role:
  - Go to the Unit of Measure window and create a new
    record. Put any name and EDI Code desired.
    Save the record and enter the Conversion Tab.
    Create a new Conversion with any To UOM and Multiple
    Rate By values.
    Save the record.
  
  #In this moment the modified HQL is executed#
(0118405)
dmiguelez   
2020-03-06 15:06   
Test Plan II

Using the data created in first test plan.
Try to create another record in the Conversion Tab for the same To UOM.
The process fails because it does not allow to create more than one conversion to the same UOM
(0118406)
hgbot   
2020-03-06 15:07   
Repository: erp/devel/pi
Changeset: ef59a5ef2626261c33d057be6a7080381f522a90
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 03 16:47:28 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ef59a5ef2626261c33d057be6a7080381f522a90 [^]

fixes BUG-43404:Applied new HQL Style

---
M src/org/openbravo/event/UOMConversionEventHandler.java
---
(0118407)
hgbot   
2020-03-06 15:07   
Repository: erp/devel/pi
Changeset: 60b69f08a51226aebd38f423e676ab1b4ddeb549
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 03 16:54:16 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/60b69f08a51226aebd38f423e676ab1b4ddeb549 [^]

related to ISSUE-43404: Finals added

-Finals added

---
M src/org/openbravo/event/UOMConversionEventHandler.java
---
(0118408)
dmiguelez   
2020-03-06 15:07   
Code Review + Testing Ok