Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043400Openbravo ERPA. Platformpublic2020-03-03 12:502020-03-06 14:51
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043400: Apply new HQL Style in OrderLineEventHandler.java
DescriptionOrderLineEventHandler.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-03 12:50inigo_lergaNew Issue
2020-03-03 12:50inigo_lergaAssigned To => inigo_lerga
2020-03-03 12:50inigo_lergaModules => Core
2020-03-03 12:50inigo_lergaTriggers an Emergency Pack => No
2020-03-03 12:50inigo_lergaRelationship addedrelated to 0041287
2020-03-03 12:50inigo_lergaStatusnew => scheduled
2020-03-03 13:27inigo_lergaNote Added: 0118295
2020-03-06 14:50hgbotCheckin
2020-03-06 14:50hgbotNote Added: 0118400
2020-03-06 14:50hgbotStatusscheduled => resolved
2020-03-06 14:50hgbotResolutionopen => fixed
2020-03-06 14:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/00befc0f7e5b88308c396bdebc0ef413479c2f7a [^]
2020-03-06 14:50hgbotCheckin
2020-03-06 14:50hgbotNote Added: 0118401
2020-03-06 14:51dmiguelezReview Assigned To => dmiguelez
2020-03-06 14:51dmiguelezNote Added: 0118402
2020-03-06 14:51dmiguelezStatusresolved => closed
2020-03-06 14:51dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118295)
inigo_lerga   
2020-03-03 13:27   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Go to the Purchase Order window and create
    a new record. Select any Business Partner desired.
    Save the record.
  - Go to the Lines Tab and create a new Line with any
    desired product.
    Save the record.
    Now delete the Line that you just created.
  
  #In this moment the modified HQL is executed#
(0118400)
hgbot   
2020-03-06 14:50   
Repository: erp/devel/pi
Changeset: 00befc0f7e5b88308c396bdebc0ef413479c2f7a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 03 13:32:23 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/00befc0f7e5b88308c396bdebc0ef413479c2f7a [^]

fixes BUG-43400:Applied new HQL Style

---
M src/org/openbravo/event/OrderLineEventHandler.java
---
(0118401)
hgbot   
2020-03-06 14:50   
Repository: erp/devel/pi
Changeset: a55b2454208f7299f26667878f4ce8d744252fe7
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 03 13:38:25 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a55b2454208f7299f26667878f4ce8d744252fe7 [^]

related to ISSUE-43400: Finals added

-Finals added

---
M src/org/openbravo/event/OrderLineEventHandler.java
---
(0118402)
dmiguelez   
2020-03-06 14:51   
Code Review + Testing Ok