Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043397Openbravo ERPA. Platformpublic2020-03-03 11:232020-03-06 14:42
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043397: Apply new HQL Style in OrderEventHandler.java
DescriptionOrderEventHandler.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-03 11:23inigo_lergaNew Issue
2020-03-03 11:23inigo_lergaAssigned To => inigo_lerga
2020-03-03 11:23inigo_lergaOBNetwork customer => No
2020-03-03 11:23inigo_lergaModules => Core
2020-03-03 11:23inigo_lergaTriggers an Emergency Pack => No
2020-03-03 11:23inigo_lergaRelationship addedrelated to 0041287
2020-03-03 11:23inigo_lergaStatusnew => scheduled
2020-03-03 12:29inigo_lergaNote Added: 0118294
2020-03-06 14:41dmiguelezNote Added: 0118395
2020-03-06 14:41hgbotCheckin
2020-03-06 14:41hgbotNote Added: 0118396
2020-03-06 14:41hgbotStatusscheduled => resolved
2020-03-06 14:41hgbotResolutionopen => fixed
2020-03-06 14:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0c47875d6942d77157a49ab8aac8390cdfb84a2c [^]
2020-03-06 14:41hgbotCheckin
2020-03-06 14:41hgbotNote Added: 0118397
2020-03-06 14:42dmiguelezReview Assigned To => dmiguelez
2020-03-06 14:42dmiguelezNote Added: 0118398
2020-03-06 14:42dmiguelezStatusresolved => closed
2020-03-06 14:42dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118294)
inigo_lerga   
2020-03-03 12:29   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Go to the Purchase Order window and create
    a new record. Select any Business Partner desired.
    Save the record.
    Now change the Business Partner to a different one
    ans save again.
  
  #In this moment the modified HQL is executed#
(0118395)
dmiguelez   
2020-03-06 14:41   
Test Plan II

Log in as F&B International Group Admin

Go to Sales Order Window and create a new record with:
  * Organization: F&B España - Región Norte
  * Business Partner: Alimentos y Supermercados
Navigate to Basic Discounts Tab and realize that there is one record with Descuento 10%
Change the Business Partner of the Header to Restaurantes Luna Llena and save
Navigate to Basic Discounts Tab and realize that there is only one record with Descuento 5%
(0118396)
hgbot   
2020-03-06 14:41   
Repository: erp/devel/pi
Changeset: 0c47875d6942d77157a49ab8aac8390cdfb84a2c
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 03 12:30:08 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0c47875d6942d77157a49ab8aac8390cdfb84a2c [^]

fixes BUG-43397:Applied new HQL Style

---
M src/org/openbravo/event/OrderEventHandler.java
---
(0118397)
hgbot   
2020-03-06 14:41   
Repository: erp/devel/pi
Changeset: 8ace6f1061cc3bceea4611ffb706de2249e88006
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 03 12:43:14 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8ace6f1061cc3bceea4611ffb706de2249e88006 [^]

related to ISSUE-43397: Finals added and code refactored

-Finals added
-Code refactored inside getOrderLines function.

---
M src/org/openbravo/event/OrderEventHandler.java
---
(0118398)
dmiguelez   
2020-03-06 14:42   
Code Review + Testing Ok