Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043396Openbravo ERPA. Platformpublic2020-03-03 11:082020-04-09 09:39
Reportermaite 
Assigned Tocberner 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesUser Interface Selector
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043396: In case selected record does not belong to the first page of records, it is removed when selecting a new record
DescriptionIn case selected record does not belong to the first page of records, it is removed when selecting a new record
Steps To Reproduce0. In an environment with more than 100 business partners (attached file to create them using Initial Data Load module)
1. Go to Payables Aging Schedule window, open Business Partner selector, scroll down until the end and select a record and press OK
2. Open Business Partner selector again and select the first record and press OK. Realize that previously added business partner has been deleted
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039644 closed alostale Add product p&e is not sorting the selected records when clearing filters 
has duplicate defect 0028923 closed platform The multiple selector on the processdefinition does not maintain the selections of records from a position bigger than 76 
Attached Filescsv bpimport.csv (12,786) 2020-03-03 11:08
https://issues.openbravo.com/file_download.php?file_id=14122&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-03-03 11:08maiteNew Issue
2020-03-03 11:08maiteAssigned To => platform
2020-03-03 11:08maiteFile Added: bpimport.csv
2020-03-03 11:08maiteModules => User Interface Selector
2020-03-03 11:08maiteResolution time => 1585004400
2020-03-03 11:08maiteTriggers an Emergency Pack => No
2020-03-03 11:08maiteIssue Monitored: networkb
2020-03-11 16:13alostaleRelationship addedrelated to 0028923
2020-03-24 18:17cbernerAssigned Toplatform => cberner
2020-04-06 10:43cbernerStatusnew => scheduled
2020-04-06 10:44cbernerNote Added: 0118942
2020-04-06 10:44cbernerReview Assigned To => alostale
2020-04-09 08:18hgbotCheckin
2020-04-09 08:18hgbotNote Added: 0119109
2020-04-09 08:18hgbotStatusscheduled => resolved
2020-04-09 08:18hgbotResolutionopen => fixed
2020-04-09 08:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e8ed5b26094715f03a44a177e41e1ca9a0c4585b [^]
2020-04-09 08:18hgbotCheckin
2020-04-09 08:18hgbotNote Added: 0119110
2020-04-09 08:30alostaleRelationship replacedhas duplicate 0028923
2020-04-09 08:35alostaleRelationship addedrelated to 0039644
2020-04-09 09:39alostaleStatusresolved => closed
2020-04-09 09:39alostaleFixed in Version => 3.0PR20Q3

Notes
(0118942)
cberner   
2020-04-06 10:44   
MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/51 [^]
(0119109)
hgbot   
2020-04-09 08:18   
Repository: erp/devel/pi
Changeset: e8ed5b26094715f03a44a177e41e1ca9a0c4585b
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Thu Apr 09 07:56:46 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e8ed5b26094715f03a44a177e41e1ca9a0c4585b [^]

Fixes ISSUE-43396: Multiselectors don't keep selection on multiple pages

In a multiple selectors, when a selected record was not in first page
and the selector was reopened, the record was not keep as selected. This
was becasue selectors datasource request assumes all selected records
were returned and selected records were not sorted on top of the rest.

This is fixed by using the same method P&E multiselection uses to:
  * Sort selected records on top of the rest
  * Check whether the full selection fits in the page size to increase
    it if neccessary to ensure the whole selection is returned in the
    request.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonConstants.java
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorComponent.java
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorConstants.java
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0119110)
hgbot   
2020-04-09 08:18   
Repository: erp/devel/pi
Changeset: dd410a29164518fe9db0e6d03a8d24df7cb49025
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Thu Apr 09 08:09:29 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dd410a29164518fe9db0e6d03a8d24df7cb49025 [^]

related to ISSUE-43396: fixed duplicates in multi selection

Both P&E and multiselector duplicated entries of selected records on
pages after the first one.

Fixed by removing those duplicates while preparing the selection.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---