Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043394Openbravo ERPA. Platformpublic2020-03-03 10:042020-03-06 14:31
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043394: Apply new HQL Style in InvoiceEventHandler.java
DescriptionInvoiceEventHandler.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-03 10:04inigo_lergaNew Issue
2020-03-03 10:04inigo_lergaAssigned To => inigo_lerga
2020-03-03 10:04inigo_lergaModules => Core
2020-03-03 10:04inigo_lergaTriggers an Emergency Pack => No
2020-03-03 10:05inigo_lergaRelationship addedrelated to 0041287
2020-03-03 10:05inigo_lergaStatusnew => scheduled
2020-03-03 12:22inigo_lergaNote Added: 0118293
2020-03-06 14:30hgbotCheckin
2020-03-06 14:30hgbotNote Added: 0118392
2020-03-06 14:30hgbotStatusscheduled => resolved
2020-03-06 14:30hgbotResolutionopen => fixed
2020-03-06 14:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/345e756478535b0254cd5a9b2f0a5dee433eb8fc [^]
2020-03-06 14:30hgbotCheckin
2020-03-06 14:30hgbotNote Added: 0118393
2020-03-06 14:31dmiguelezReview Assigned To => dmiguelez
2020-03-06 14:31dmiguelezNote Added: 0118394
2020-03-06 14:31dmiguelezStatusresolved => closed
2020-03-06 14:31dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118293)
inigo_lerga   
2020-03-03 12:22   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Go to the Purchase Invoice window and create
    a new record. Select any Business Partner desired.
    Save the record.
    Now change the Business Partner to a different one
    ans save again.
  
  #In this moment the modified HQL is executed#
(0118392)
hgbot   
2020-03-06 14:30   
Repository: erp/devel/pi
Changeset: 345e756478535b0254cd5a9b2f0a5dee433eb8fc
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 03 11:14:42 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/345e756478535b0254cd5a9b2f0a5dee433eb8fc [^]

fixes BUG-43394:Applied new HQL Style

---
M src/org/openbravo/event/InvoiceEventHandler.java
---
(0118393)
hgbot   
2020-03-06 14:30   
Repository: erp/devel/pi
Changeset: c65a5e95a092a30669d9a4a1f1aee4c424eb62dc
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 03 11:18:01 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c65a5e95a092a30669d9a4a1f1aee4c424eb62dc [^]

related to ISSUE-43394: Finals added
-Finals added
-No sonarlint suggestions found

---
M src/org/openbravo/event/InvoiceEventHandler.java
---
(0118394)
dmiguelez   
2020-03-06 14:31   
Code Review + Testing Ok