Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043391Openbravo ERP00. Application dictionarypublic2020-03-02 18:122020-03-18 08:35
ReporterAtulOpenbravo 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043391: API Change: Remove deprecated properties
DescriptionRemove below deprecated properties

**Columns from DB table

- C_BP_BANKACCOUNT.SHOWACCOUNTNO
- C_BP_BANKACCOUNT.SHOWIBAN
- C_INVOICE.PAYMENTRULE
- C_INVOICELINE.TAXAMT
- GL_JOURNALLINE.DATEACCT

**Its associated AD_Column and its related AD_Field from Application Dictionary

**Below fields and its getter and setter methods from java classes

org.openbravo.model.common.businesspartner.BankAccount.PROPERTY_SHOWGENERIC
org.openbravo.model.common.businesspartner.BankAccount.PROPERTY_SHOWIBAN
org.openbravo.model.common.invoice.Invoice.PROPERTY_FINORIGPAYMENTSCHEDULELIST
org.openbravo.model.common.invoice.Invoice.PROPERTY_FORMOFPAYMENT
org.openbravo.model.common.invoice.InvoiceLine.PROPERTY_TAXAMOUNT
org.openbravo.model.common.invoice.InvoiceV2.PROPERTY_FORMOFPAYMENT
org.openbravo.model.financialmgmt.gl.GLJournalLine.PROPERTY_ACCOUNTINGDATE
org.openbravo.model.financialmgmt.payment.FIN_PaymentDetailV.PROPERTY_INVOICEPAYMENTPLAN
org.openbravo.model.financialmgmt.payment.FIN_PaymentSchedInvV.PROPERTY_FINPAYMENTDETAILVLIST

Above properties are safe to remove hence has a low risk. References from sample data modules could be managed for the removed columns.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0043435 closed AtulOpenbravo Remove deprecated column PaymentRule from C_invoice 
related to defect 0043436 closed AtulOpenbravo Remove deprecated column TaxAmt from C_invoiceLine 
related to defect 0043437 closed AtulOpenbravo Remove deprecated column SHOWACCOUNTNO and SHOWIBAN from C_BP_BANKACCOUNT table 
related to defect 0043438 closed AtulOpenbravo Remove deprecated column DateAcct from GL_JournalLine 
related to defect 0043439 closed AtulOpenbravo Remove column Fin_Payment_Sched_Inv_V_Id from FIN_PAYMENT_DETAIL_V view 
blocks defect 0042665 closed AtulOpenbravo Deprecated properties usage should be removed in ERP modules 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-02 18:12AtulOpenbravoNew Issue
2020-03-02 18:12AtulOpenbravoAssigned To => AtulOpenbravo
2020-03-02 18:12AtulOpenbravoModules => Core
2020-03-02 18:12AtulOpenbravoTriggers an Emergency Pack => No
2020-03-02 18:12AtulOpenbravoIssue generated from0043368
2020-03-02 18:12AtulOpenbravoRelationship addedblocks 0042665
2020-03-02 18:14AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=20500#r20500
2020-03-02 18:14AtulOpenbravoStatusnew => scheduled
2020-03-10 09:30hgbotCheckin
2020-03-10 09:30hgbotNote Added: 0118449
2020-03-10 09:30hgbotCheckin
2020-03-10 09:30hgbotNote Added: 0118450
2020-03-10 09:30hgbotCheckin
2020-03-10 09:30hgbotNote Added: 0118451
2020-03-10 09:30hgbotCheckin
2020-03-10 09:30hgbotNote Added: 0118452
2020-03-10 09:30hgbotCheckin
2020-03-10 09:30hgbotNote Added: 0118453
2020-03-10 09:30hgbotCheckin
2020-03-10 09:30hgbotNote Added: 0118454
2020-03-10 16:44dmiguelezRelationship addedrelated to 0043435
2020-03-10 16:45dmiguelezRelationship addedrelated to 0043436
2020-03-10 16:45dmiguelezRelationship addedrelated to 0043437
2020-03-10 16:45dmiguelezRelationship addedrelated to 0043438
2020-03-10 16:45dmiguelezRelationship addedrelated to 0043439
2020-03-10 16:47dmiguelezStatusscheduled => resolved
2020-03-10 16:47dmiguelezFixed in Version => 3.0PR20Q2
2020-03-10 16:47dmiguelezFixed in SCM revision => https://code.openbravo.com/erp/devel/api-checks/rev/c8d04327aa9ffc87fc70b73ea5fa48fe999bfeb0 [^]
2020-03-10 16:47dmiguelezResolutionopen => fixed
2020-03-10 16:47dmiguelezReview Assigned To => dmiguelez
2020-03-10 16:47dmiguelezNote Added: 0118479
2020-03-10 16:47dmiguelezStatusresolved => closed
2020-03-18 08:35hgbotCheckin
2020-03-18 08:35hgbotNote Added: 0118658
2020-03-18 08:35hgbotCheckin
2020-03-18 08:35hgbotNote Added: 0118659
2020-03-18 08:35hgbotCheckin
2020-03-18 08:35hgbotNote Added: 0118660
2020-03-18 08:35hgbotCheckin
2020-03-18 08:35hgbotNote Added: 0118661
2020-03-18 08:35hgbotCheckin
2020-03-18 08:35hgbotNote Added: 0118662
2020-03-18 08:35hgbotCheckin
2020-03-18 08:35hgbotNote Added: 0118663

Notes
(0118449)
hgbot   
2020-03-10 09:30   
Repository: erp/devel/api-checks
Changeset: 8e73bddd61070dc6ca28ba8024cc553f9972d094
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 23:20:08 2020 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/8e73bddd61070dc6ca28ba8024cc553f9972d094 [^]

Related to BUG-43391: API Change: Remove deprecated properties

**Remove paymentule column from DB table C_Invoice and its
references in AD_COLUMN and AD_FIELD

---
M model/src-db/database/model/tables/C_INVOICE.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0118450)
hgbot   
2020-03-10 09:30   
Repository: erp/devel/api-checks
Changeset: 823c3e30c9169d29eddbb31bfc59add4525ccffa
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 23:22:44 2020 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/823c3e30c9169d29eddbb31bfc59add4525ccffa [^]

Related to BUG-43391: API Change: Remove deprecated properties

**Remove taxamt column from DB table C_Invoiceline and its
references in AD_COLUMN and AD_FIELD

---
M model/src-db/database/model/tables/C_INVOICELINE.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0118451)
hgbot   
2020-03-10 09:30   
Repository: erp/devel/api-checks
Changeset: b219371ad3e4910a16953989f2c2ef407b1b81ca
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 23:25:34 2020 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/b219371ad3e4910a16953989f2c2ef407b1b81ca [^]

Related to BUG-43391: API Change: Remove deprecated properties

**Remove showaccountno, showiban column from DB table
C_BP_BANK_ACCOUNT and its references in AD_COLUMN and AD_FIELD

---
M model/src-db/database/model/tables/C_BP_BANKACCOUNT.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0118452)
hgbot   
2020-03-10 09:30   
Repository: erp/devel/api-checks
Changeset: 634c4dde62cf259c131071e00e9c456b56fcaf85
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 23:27:45 2020 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/634c4dde62cf259c131071e00e9c456b56fcaf85 [^]

Related to BUG-43391: API Change: Remove deprecated properties

**Remove dateacct column from DB table GL_Journalline and its
references in AD_COLUMN and AD_FIELD

---
M model/src-db/database/model/tables/GL_JOURNALLINE.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0118453)
hgbot   
2020-03-10 09:30   
Repository: erp/devel/api-checks
Changeset: 7db1d033210568ca85e1a9ca3ec7a0b64d43f303
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 23:31:43 2020 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/7db1d033210568ca85e1a9ca3ec7a0b64d43f303 [^]

Related to BUG-43391: API Change: Remove deprecated properties

**Remove references of FIN_PaymentDetailV.PROPERTY_INVOICEPAYMENTPLAN
in AD_COLUMN and AD_FIELD

---
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0118454)
hgbot   
2020-03-10 09:30   
Repository: erp/devel/api-checks
Changeset: c8d04327aa9ffc87fc70b73ea5fa48fe999bfeb0
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 23:34:45 2020 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/c8d04327aa9ffc87fc70b73ea5fa48fe999bfeb0 [^]

Related to BUG-43391: API Change: Remove deprecated properties

**Set IS_CHILD_PROPERTY_IN_PARENT as No, so that property
PROPERTY_FINORIGPAYMENTSCHEDULELIST is not generated
in the Invoice class.

---
M model/src-db/database/sourcedata/AD_COLUMN.xml
---
(0118479)
dmiguelez   
2020-03-10 16:47   
Code Review + Testing Ok
(0118658)
hgbot   
2020-03-18 08:35   
Repository: erp/devel/api-checks
Changeset: 4ae4fab8678a565eb35f77267a22700d50fcf48a
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 23:20:08 2020 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/4ae4fab8678a565eb35f77267a22700d50fcf48a [^]

Related to BUG-43391: API Change: Remove deprecated properties

**Remove paymentule column from DB table C_Invoice and its
references in AD_COLUMN and AD_FIELD

---
M model/src-db/database/model/tables/C_INVOICE.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0118659)
hgbot   
2020-03-18 08:35   
Repository: erp/devel/api-checks
Changeset: 15bc002ccc2b33be56e352d0c82acd30418ad789
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 23:22:44 2020 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/15bc002ccc2b33be56e352d0c82acd30418ad789 [^]

Related to BUG-43391: API Change: Remove deprecated properties

**Remove taxamt column from DB table C_Invoiceline and its
references in AD_COLUMN and AD_FIELD

---
M model/src-db/database/model/tables/C_INVOICELINE.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0118660)
hgbot   
2020-03-18 08:35   
Repository: erp/devel/api-checks
Changeset: df9b0edd8d71792d1fbcc360541ad58d6886492a
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 23:25:34 2020 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/df9b0edd8d71792d1fbcc360541ad58d6886492a [^]

Related to BUG-43391: API Change: Remove deprecated properties

**Remove showaccountno, showiban column from DB table
C_BP_BANK_ACCOUNT and its references in AD_COLUMN and AD_FIELD

---
M model/src-db/database/model/tables/C_BP_BANKACCOUNT.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0118661)
hgbot   
2020-03-18 08:35   
Repository: erp/devel/api-checks
Changeset: 9cca675f5d7814b52a5a3f996fa9f12a6b5d7712
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 23:27:45 2020 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/9cca675f5d7814b52a5a3f996fa9f12a6b5d7712 [^]

Related to BUG-43391: API Change: Remove deprecated properties

**Remove dateacct column from DB table GL_Journalline and its
references in AD_COLUMN and AD_FIELD

---
M model/src-db/database/model/tables/GL_JOURNALLINE.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0118662)
hgbot   
2020-03-18 08:35   
Repository: erp/devel/api-checks
Changeset: 21cc4c180c78b49fffcf063757ef0d8996baf50a
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 23:31:43 2020 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/21cc4c180c78b49fffcf063757ef0d8996baf50a [^]

Related to BUG-43391: API Change: Remove deprecated properties

**Remove references of FIN_PaymentDetailV.PROPERTY_INVOICEPAYMENTPLAN
in AD_COLUMN and AD_FIELD

---
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0118663)
hgbot   
2020-03-18 08:35   
Repository: erp/devel/api-checks
Changeset: 8a173395a3dbf6c91b24a600afb8d58ade66b64a
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 23:34:45 2020 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/8a173395a3dbf6c91b24a600afb8d58ade66b64a [^]

Related to BUG-43391: API Change: Remove deprecated properties

**Set IS_CHILD_PROPERTY_IN_PARENT as No, so that property
PROPERTY_FINORIGPAYMENTSCHEDULELIST is not generated
in the Invoice class.

---
M model/src-db/database/sourcedata/AD_COLUMN.xml
---