Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043387Openbravo ERPA. Platformpublic2020-03-02 14:592020-03-06 13:57
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043387: Apply new HQL Style in OBLedgerUtils.java
DescriptionOBLedgerUtils.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-02 14:59inigo_lergaNew Issue
2020-03-02 14:59inigo_lergaAssigned To => inigo_lerga
2020-03-02 14:59inigo_lergaModules => Core
2020-03-02 14:59inigo_lergaTriggers an Emergency Pack => No
2020-03-02 14:59inigo_lergaRelationship addedrelated to 0041287
2020-03-02 14:59inigo_lergaStatusnew => scheduled
2020-03-02 15:51inigo_lergaNote Added: 0118251
2020-03-06 13:57hgbotCheckin
2020-03-06 13:57hgbotNote Added: 0118381
2020-03-06 13:57hgbotStatusscheduled => resolved
2020-03-06 13:57hgbotResolutionopen => fixed
2020-03-06 13:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/daabf9ba26d7080c5d836a54aedc9db323fde134 [^]
2020-03-06 13:57hgbotCheckin
2020-03-06 13:57hgbotNote Added: 0118382
2020-03-06 13:57dmiguelezReview Assigned To => dmiguelez
2020-03-06 13:57dmiguelezNote Added: 0118383
2020-03-06 13:57dmiguelezStatusresolved => closed
2020-03-06 13:57dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118251)
inigo_lerga   
2020-03-02 15:51   
--Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Go to the Journal Entries Report window and
    select "*" as Organization.
  
  #In this moment the modified HQL is executed#
(0118381)
hgbot   
2020-03-06 13:57   
Repository: erp/devel/pi
Changeset: daabf9ba26d7080c5d836a54aedc9db323fde134
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Mar 02 15:59:28 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/daabf9ba26d7080c5d836a54aedc9db323fde134 [^]

fixes BUG-43387:Applied new HQL Style

---
M src/org/openbravo/erpCommon/utility/OBLedgerUtils.java
---
(0118382)
hgbot   
2020-03-06 13:57   
Repository: erp/devel/pi
Changeset: 011cac91669ac01382752571be8763f5c21c50d3
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Mar 02 16:12:45 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/011cac91669ac01382752571be8763f5c21c50d3 [^]

related to ISSUE-43387: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

---
M src/org/openbravo/erpCommon/utility/OBLedgerUtils.java
---
(0118383)
dmiguelez   
2020-03-06 13:57   
Code Review + Testing Ok