Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043383Retail ModulesWeb POSpublic2020-03-02 13:562020-03-30 08:36
Reporteravicente 
Assigned Toprakashmurugesan88 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043383: wrong behaviour in the hook OBMOBC_PrePaymentSelected
Description1. The hook OBMOBC_PrePaymentSelected is executed not only when a payment method is selected (that's right) but also when any key in the keyboard is clicked, for example a number key, that is wrong.

2. In addition, when the total amount button is clicked, by default, there is always a selected payment method. In this case, the hook is not executed and it should be.
Steps To ReproduceN/A check hook OBMOBC_PrePaymentSelected
Proposed SolutionFor the first point, just call to the hook when payment method keys are clicked.

For the second point, call to the hook when the total amount button is clicked for the by default payment method
Additional Information
TagsNo tags attached.
Relationships
related to defect 0045293 closed ranjith_qualiantech_com No payment button selected in WEBPOS by default when there is a group provider (19Q3) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-03-02 13:56avicenteNew Issue
2020-03-02 13:56avicenteAssigned To => Retail
2020-03-02 13:56avicenteResolution time => 1584918000
2020-03-02 13:56avicenteTriggers an Emergency Pack => No
2020-03-17 07:34prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-03-17 07:34prakashmurugesan88Statusnew => scheduled
2020-03-23 15:56hgbotCheckin
2020-03-23 15:56hgbotNote Added: 0118762
2020-03-23 15:56hgbotStatusscheduled => resolved
2020-03-23 15:56hgbotResolutionopen => fixed
2020-03-23 15:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/71e718824612d1d8db46678ac22051c283f69d1d [^]
2020-03-23 15:59hgbotCheckin
2020-03-23 15:59hgbotNote Added: 0118763
2020-03-23 15:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/71e718824612d1d8db46678ac22051c283f69d1d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2b7bdaa8c5f79f224e24e3d783eff12f92c338ce [^]
2020-03-23 16:30hgbotCheckin
2020-03-23 16:30hgbotNote Added: 0118765
2020-03-30 08:36marvintmReview Assigned To => marvintm
2020-03-30 08:36marvintmStatusresolved => closed
2020-03-30 08:36marvintmFixed in Version => RR20Q2
2020-10-29 06:59ranjith_qualiantech_comRelationship addedrelated to 0045293

Notes
(0118762)
hgbot   
2020-03-23 15:56   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 71e718824612d1d8db46678ac22051c283f69d1d
Author: Prakash M <prakash <at> qualiantech.com>
Date: Mon Mar 23 15:55:00 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/71e718824612d1d8db46678ac22051c283f69d1d [^]

Fixed BUG-43383: OBMOBC_PrePaymentSelected hook will be called only on payment select

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0118763)
hgbot   
2020-03-23 15:59   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2b7bdaa8c5f79f224e24e3d783eff12f92c338ce
Author: Prakash M <prakash <at> qualiantech.com>
Date: Tue Mar 17 18:07:04 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2b7bdaa8c5f79f224e24e3d783eff12f92c338ce [^]

Fixed BUG-43383: OBMOBC_PrePaymentSelected hook will be called on default payment select

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---
(0118765)
hgbot   
2020-03-23 16:30   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 33f6644c80b38130d53784d8441361ef20fc26c3
Author: Prakash M <prakash <at> qualiantech.com>
Date: Mon Mar 23 20:57:57 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/33f6644c80b38130d53784d8441361ef20fc26c3 [^]

Related to BUG-43383: Included paymentInfo param in OBMOBC_PrePaymentSelected hook

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---