Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0043381Openbravo ERPA. Platformpublic2020-03-02 12:132020-03-06 13:38
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
3.0PR20Q2 
dmiguelez
Core
No
0043381: Apply new HQL Style in DimensionDisplayUtility.java
DimensionDisplayUtility.java has eight HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Issue History
2020-03-02 12:13inigo_lergaNew Issue
2020-03-02 12:13inigo_lergaAssigned To => inigo_lerga
2020-03-02 12:13inigo_lergaModules => Core
2020-03-02 12:13inigo_lergaTriggers an Emergency Pack => No
2020-03-02 12:13inigo_lergaStatusnew => scheduled
2020-03-02 12:13inigo_lergaRelationship addedrelated to 0041287
2020-03-02 14:01inigo_lergaNote Added: 0118249
2020-03-06 13:37hgbotCheckin
2020-03-06 13:37hgbotNote Added: 0118376
2020-03-06 13:37hgbotStatusscheduled => resolved
2020-03-06 13:37hgbotResolutionopen => fixed
2020-03-06 13:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/254835a6247340fa54c2f1a5a20a3668f439f0e8 [^]
2020-03-06 13:37hgbotCheckin
2020-03-06 13:37hgbotNote Added: 0118377
2020-03-06 13:38dmiguelezReview Assigned To => dmiguelez
2020-03-06 13:38dmiguelezNote Added: 0118378
2020-03-06 13:38dmiguelezStatusresolved => closed
2020-03-06 13:38dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0118249)
inigo_lerga   
2020-03-02 14:01   
--Test Plan Mantis HQL queries--
The first query is executed when the Openbravo instance is
open in the web browser.

As the F&B International Group Admin role:
  - Go to the Purchase Invoice window.
  
  #In this moment three of the modified HQLs are executed#

  - Go to the Financial Account window.

  #In this moment two of the modified HQLs are executed#

As the System Administrator role:
  - Go to the Initial Client Setup and select USD as Currency.
    Put any desired Password and Confirmed Password.
    Uncheck the Include accounting checkbox.
    Press the OK button.

  #In this moment the last modified HQL is executed#
(0118376)
hgbot   
2020-03-06 13:37   
Repository: erp/devel/pi
Changeset: 254835a6247340fa54c2f1a5a20a3668f439f0e8
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Mar 02 13:50:33 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/254835a6247340fa54c2f1a5a20a3668f439f0e8 [^]

fixes BUG-43381:Applied new HQL Style

---
M src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java
---
(0118377)
hgbot   
2020-03-06 13:37   
Repository: erp/devel/pi
Changeset: 2f27b3d81a1716dde7ba949b82a59fdedb0c4945
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Mar 02 14:43:26 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2f27b3d81a1716dde7ba949b82a59fdedb0c4945 [^]

related to ISSUE-43381: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

---
M src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java
---
(0118378)
dmiguelez   
2020-03-06 13:38   
Code Review + Testing Ok